[MOAB-dev] OCC STP file loading and senses interpretation

[Patrick Shriwise]

Excellent to hear! I'll try pulling down both of these branches for an 
oce build I have and see how the faceting of a few simple geometries goes.

Thanks for catching that error in the check_sense_data method. You're 
right about the intent of this method and those lines should stay.

On 08/28/2015 02:43 PM, jain at mcs.anl.gov wrote:
> See the message below from Evan. Does anyone have concerns about this 
> change?
> CGM change: 
> https://bitbucket.org/fathomteam/cgm/branch/vanderzee/faceVolSense
> caused MOAB change: 
> https://bitbucket.org/fathomteam/moab/branch/vanderzee/faceVolSense
>
> On Friday, August 28, 2015 2:21 PM, "Vander Zee, Evan B." 
> <vanderzee at anl.gov> wrote:
>
>
> In review of the pull request I created, it came up that the 
> read_cgm_senses_test of MOAB was broken by this change.  I have pushed 
> an updated version of that test to a vanderzee/faceVolSense branch of 
> the MOAB repository.  With that change, my local build of moab-oce 
> passes all of the tests in make check.
> This particular test has hard-coded what face-to-volume and 
> edge-to-face senses it expects to get when it reads 
> MeshFiles/unittest/io/cylcube.stp file.  The geometry contains two 
> volumes, a cube and a cylinder, that do not touch or overlap.  Since 
> my changes to CGM now produce normal vectors and face-to-volume senses 
> that are in accordance with what is stored in the .stp file rather 
> than always producing a forward sense on all faces and not having the 
> sense in accordance with the normal vector, and since some of the 
> faces in the .stp file have reversed sense, the face-to-volume and 
> edge-to-face senses that this test expects needed to be changed.
> In the attached spreadsheet – which I think will open in OpenOffice if 
> you don’t have Excel – I describe the changes I’ve made in a way 
> that’s probably a bit easier to understand than the code. I have an 
> initial table that shows how all 10 faces expected a forward (F) 
> sense, but now half of them expect a reverse (R) sense. In the lower 
> table I list the edge-to-face senses. Here the expectation is that 
> wherever the sense of a face has changed to the reverse sense, the 
> sense of the edge with respect to that face should flip.  You should 
> be able to see how my changes respect that.  Also, the order in which 
> the edges are read changed slightly, so edges 6 and 8 swapped IDs.
> I also made some changes to the check_sense_data method of the test so 
> that the test does not depend on having the known senses and the 
> senses read from the file in the same order. This seemed to be the 
> intent of that method, but was not behaving that way. If the test is 
> supposed to depend on reading things in the same order, you can revert 
> the two lines I added to that method, and the test will still pass. 
> Finally, I changed the test to check the face-to-volume senses before 
> it checks the edge-to-face senses, because the expectation one has for 
> edge-to-face sense depends on the face-to-volume sense. That reflects 
> a preference that I have, but again, is not at all essential.
> -Evan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/moab-dev/attachments/20150828/c2ede0ad/attachment-0001.html>