<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
Excellent to hear! I'll try pulling down both of these branches for
an oce build I have and see how the faceting of a few simple
geometries goes. <br>
<br>
Thanks for catching that error in the check_sense_data method.
You're right about the intent of this method and those lines should
stay.<br>
<br>
<div class="moz-cite-prefix">On 08/28/2015 02:43 PM,
<a class="moz-txt-link-abbreviated" href="mailto:jain@mcs.anl.gov">jain@mcs.anl.gov</a> wrote:<br>
</div>
<blockquote
cite="mid:818387600.2414392.1440791011275.JavaMail.yahoo@mail.yahoo.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div style="color:#000; background-color:#fff;
font-family:verdana, helvetica, sans-serif;font-size:13px">
<div id="yui_3_16_0_1_1440691798378_251093" dir="ltr"><span
id="yui_3_16_0_1_1440691798378_251100">See the message below
from Evan. Does anyone have concerns about this change?</span></div>
<div id="yui_3_16_0_1_1440691798378_251093" dir="ltr">CGM
change: <a moz-do-not-send="true"
href="https://bitbucket.org/fathomteam/cgm/branch/vanderzee/faceVolSense"
id="yui_3_16_0_1_1440691798378_252416"
style="background-color: rgb(255, 255, 255);">https://bitbucket.org/fathomteam/cgm/branch/vanderzee/faceVolSense</a><br>
</div>
<div class="signature" id="yui_3_16_0_1_1440691798378_251696">
<div id="yui_3_16_0_1_1440623997177_20748"
style="font-family:verdana, helvetica,
sans-serif;font-size:13px;" dir="ltr">caused MOAB change: <a
moz-do-not-send="true"
href="https://bitbucket.org/fathomteam/moab/branch/vanderzee/faceVolSense"
id="yui_3_16_0_1_1440691798378_251707"><a class="moz-txt-link-freetext" href="https://bitbucket.org/fathomteam/moab/branch/vanderzee/faceVolSense">https://bitbucket.org/fathomteam/moab/branch/vanderzee/faceVolSense</a></a></div>
</div>
<div class="qtdSeparateBR"
id="yui_3_16_0_1_1440691798378_252606"><br>
</div>
<div class="yahoo_quoted" id="yui_3_16_0_1_1440691798378_252051"
style="display: block;">
<div style="font-family: verdana, helvetica, sans-serif;
font-size: 13px;" id="yui_3_16_0_1_1440691798378_252050">
<div style="font-family: HelveticaNeue, Helvetica Neue,
Helvetica, Arial, Lucida Grande, sans-serif; font-size:
16px;" id="yui_3_16_0_1_1440691798378_252049">
<div dir="ltr" id="yui_3_16_0_1_1440691798378_252273"> <font
id="yui_3_16_0_1_1440691798378_252272" face="Arial"
size="2"> On Friday, August 28, 2015 2:21 PM, "Vander
Zee, Evan B." <a class="moz-txt-link-rfc2396E" href="mailto:vanderzee@anl.gov"><vanderzee@anl.gov></a> wrote:<br>
</font> </div>
<br>
<br>
<div class="y_msg_container"
id="yui_3_16_0_1_1440691798378_252048">
<div id="yiv8444884465">
<style>#yiv8444884465 #yiv8444884465 --
_filtered #yiv8444884465 {font-family:Helvetica;panose-1:2 11 6 4 2 2 2 2 2 4;}
_filtered #yiv8444884465 {font-family:Helvetica;panose-1:2 11 6 4 2 2 2 2 2 4;}
_filtered #yiv8444884465 {font-family:Calibri;panose-1:2 15 5 2 2 2 4 3 2 4;}
_filtered #yiv8444884465 {font-family:Tahoma;panose-1:2 11 6 4 3 5 4 4 2 4;}
_filtered #yiv8444884465 {font-family:Verdana;panose-1:2 11 6 4 3 5 4 4 2 4;}
#yiv8444884465
#yiv8444884465 p.yiv8444884465MsoNormal, #yiv8444884465 li.yiv8444884465MsoNormal, #yiv8444884465 div.yiv8444884465MsoNormal
{margin:0in;margin-bottom:.0001pt;font-size:12.0pt;}
#yiv8444884465 a:link, #yiv8444884465 span.yiv8444884465MsoHyperlink
{color:blue;text-decoration:underline;}
#yiv8444884465 a:visited, #yiv8444884465 span.yiv8444884465MsoHyperlinkFollowed
{color:purple;text-decoration:underline;}
#yiv8444884465 p
{margin-right:0in;margin-left:0in;font-size:12.0pt;}
#yiv8444884465 p.yiv8444884465MsoAcetate, #yiv8444884465 li.yiv8444884465MsoAcetate, #yiv8444884465 div.yiv8444884465MsoAcetate
{margin:0in;margin-bottom:.0001pt;font-size:8.0pt;}
#yiv8444884465 p.yiv8444884465msoacetate, #yiv8444884465 li.yiv8444884465msoacetate, #yiv8444884465 div.yiv8444884465msoacetate
{margin-right:0in;margin-left:0in;font-size:12.0pt;}
#yiv8444884465 p.yiv8444884465msonormal, #yiv8444884465 li.yiv8444884465msonormal, #yiv8444884465 div.yiv8444884465msonormal
{margin-right:0in;margin-left:0in;font-size:12.0pt;}
#yiv8444884465 p.yiv8444884465msochpdefault, #yiv8444884465 li.yiv8444884465msochpdefault, #yiv8444884465 div.yiv8444884465msochpdefault
{margin-right:0in;margin-left:0in;font-size:12.0pt;}
#yiv8444884465 p.yiv8444884465msonormal1, #yiv8444884465 li.yiv8444884465msonormal1, #yiv8444884465 div.yiv8444884465msonormal1
{margin-right:0in;margin-left:0in;font-size:12.0pt;}
#yiv8444884465 p.yiv8444884465msoacetate1, #yiv8444884465 li.yiv8444884465msoacetate1, #yiv8444884465 div.yiv8444884465msoacetate1
{margin-right:0in;margin-left:0in;font-size:12.0pt;}
#yiv8444884465 p.yiv8444884465msochpdefault1, #yiv8444884465 li.yiv8444884465msochpdefault1, #yiv8444884465 div.yiv8444884465msochpdefault1
{margin-right:0in;margin-left:0in;font-size:12.0pt;}
#yiv8444884465 span.yiv8444884465msohyperlink
{}
#yiv8444884465 span.yiv8444884465msohyperlinkfollowed
{}
#yiv8444884465 span.yiv8444884465balloontextchar
{}
#yiv8444884465 span.yiv8444884465msohyperlink1
{}
#yiv8444884465 span.yiv8444884465msohyperlinkfollowed1
{}
#yiv8444884465 span.yiv8444884465emailstyle181
{}
#yiv8444884465 span.yiv8444884465balloontextchar1
{}
#yiv8444884465 span.yiv8444884465emailstyle34
{}
#yiv8444884465 span.yiv8444884465emailstyle35
{}
#yiv8444884465 p.yiv8444884465msonormal2, #yiv8444884465 li.yiv8444884465msonormal2, #yiv8444884465 div.yiv8444884465msonormal2
{margin:0in;margin-bottom:.0001pt;font-size:12.0pt;}
#yiv8444884465 span.yiv8444884465msohyperlink2
{color:blue;text-decoration:underline;}
#yiv8444884465 span.yiv8444884465msohyperlinkfollowed2
{color:purple;text-decoration:underline;}
#yiv8444884465 p.yiv8444884465msoacetate2, #yiv8444884465 li.yiv8444884465msoacetate2, #yiv8444884465 div.yiv8444884465msoacetate2
{margin:0in;margin-bottom:.0001pt;font-size:12.0pt;}
#yiv8444884465 span.yiv8444884465balloontextchar2
{}
#yiv8444884465 p.yiv8444884465msonormal3, #yiv8444884465 li.yiv8444884465msonormal3, #yiv8444884465 div.yiv8444884465msonormal3
{margin-right:0in;margin-left:0in;font-size:12.0pt;}
#yiv8444884465 p.yiv8444884465msochpdefault2, #yiv8444884465 li.yiv8444884465msochpdefault2, #yiv8444884465 div.yiv8444884465msochpdefault2
{margin-right:0in;margin-left:0in;font-size:12.0pt;}
#yiv8444884465 p.yiv8444884465msonormal11, #yiv8444884465 li.yiv8444884465msonormal11, #yiv8444884465 div.yiv8444884465msonormal11
{margin:0in;margin-bottom:.0001pt;font-size:12.0pt;}
#yiv8444884465 p.yiv8444884465msoacetate11, #yiv8444884465 li.yiv8444884465msoacetate11, #yiv8444884465 div.yiv8444884465msoacetate11
{margin:0in;margin-bottom:.0001pt;font-size:8.0pt;}
#yiv8444884465 p.yiv8444884465msochpdefault11, #yiv8444884465 li.yiv8444884465msochpdefault11, #yiv8444884465 div.yiv8444884465msochpdefault11
{margin:0in;margin-bottom:.0001pt;font-size:10.0pt;}
#yiv8444884465 span.yiv8444884465msohyperlink11
{color:blue;text-decoration:underline;}
#yiv8444884465 span.yiv8444884465msohyperlinkfollowed11
{color:purple;text-decoration:underline;}
#yiv8444884465 span.yiv8444884465emailstyle1811
{color:#1F497D;}
#yiv8444884465 span.yiv8444884465balloontextchar11
{}
#yiv8444884465 span.yiv8444884465emailstyle341
{color:#1F497D;}
#yiv8444884465 span.yiv8444884465emailstyle351
{color:#1F497D;}
#yiv8444884465 span.yiv8444884465EmailStyle49
{color:#1F497D;}
#yiv8444884465 span.yiv8444884465BalloonTextChar
{}
#yiv8444884465 .yiv8444884465MsoChpDefault
{font-size:10.0pt;}
_filtered #yiv8444884465 {margin:1.0in 1.0in 1.0in 1.0in;}
#yiv8444884465 div.yiv8444884465WordSection1
{}
#yiv8444884465 </style>
<div id="yui_3_16_0_1_1440691798378_252047">
<div class="yiv8444884465WordSection1"
id="yui_3_16_0_1_1440691798378_252046">
<div class="yiv8444884465MsoNormal"
id="yui_3_16_0_1_1440691798378_252271"><span
style="font-size:11.0pt;"
id="yui_3_16_0_1_1440691798378_252270">In
review of the pull request I created, it came
up that the read_cgm_senses_test of MOAB was
broken by this change. I have pushed an
updated version of that test to a
vanderzee/faceVolSense branch of the MOAB
repository. With that change, my local build
of moab-oce passes all of the tests in make
check.</span></div>
<div class="yiv8444884465MsoNormal"
id="yui_3_16_0_1_1440691798378_252661"><span
style="font-size:11.0pt;"> </span></div>
<div class="yiv8444884465MsoNormal"
id="yui_3_16_0_1_1440691798378_252798"><span
style="font-size:11.0pt;"
id="yui_3_16_0_1_1440691798378_252797">This
particular test has hard-coded what
face-to-volume and edge-to-face senses it
expects to get when it reads
MeshFiles/unittest/io/cylcube.stp file. The
geometry contains two volumes, a cube and a
cylinder, that do not touch or overlap. Since
my changes to CGM now produce normal vectors
and face-to-volume senses that are in
accordance with what is stored in the .stp
file rather than always producing a forward
sense on all faces and not having the sense in
accordance with the normal vector, and since
some of the faces in the .stp file have
reversed sense, the face-to-volume and
edge-to-face senses that this test expects
needed to be changed.</span></div>
<div class="yiv8444884465MsoNormal"
id="yui_3_16_0_1_1440691798378_252269"><span
style="font-size:11.0pt;"> </span></div>
<div class="yiv8444884465MsoNormal"
id="yui_3_16_0_1_1440691798378_252268"><span
style="font-size:11.0pt;"
id="yui_3_16_0_1_1440691798378_252267">In the
attached spreadsheet – which I think will open
in OpenOffice if you don’t have Excel – I
describe the changes I’ve made in a way that’s
probably a bit easier to understand than the
code. I have an initial table that shows how
all 10 faces expected a forward (F) sense, but
now half of them expect a reverse (R) sense.
In the lower table I list the edge-to-face
senses. Here the expectation is that wherever
the sense of a face has changed to the reverse
sense, the sense of the edge with respect to
that face should flip. You should be able to
see how my changes respect that. Also, the
order in which the edges are read changed
slightly, so edges 6 and 8 swapped IDs.</span></div>
<div class="yiv8444884465MsoNormal"
id="yui_3_16_0_1_1440691798378_252266"><span
style="font-size:11.0pt;"> </span></div>
<div class="yiv8444884465MsoNormal"
id="yui_3_16_0_1_1440691798378_252265"><span
style="font-size:11.0pt;"
id="yui_3_16_0_1_1440691798378_252264">I also
made some changes to the check_sense_data
method of the test so that the test does not
depend on having the known senses and the
senses read from the file in the same order.
This seemed to be the intent of that method,
but was not behaving that way. If the test is
supposed to depend on reading things in the
same order, you can revert the two lines I
added to that method, and the test will still
pass. Finally, I changed the test to check the
face-to-volume senses before it checks the
edge-to-face senses, because the expectation
one has for edge-to-face sense depends on the
face-to-volume sense. That reflects a
preference that I have, but again, is not at
all essential.</span></div>
<div class="yiv8444884465MsoNormal"
id="yui_3_16_0_1_1440691798378_252263"><span
style="font-size:11.0pt;"
id="yui_3_16_0_1_1440691798378_252811"> </span></div>
<div class="yiv8444884465MsoNormal"
id="yui_3_16_0_1_1440691798378_252810"><span
style="font-size:11.0pt;"
id="yui_3_16_0_1_1440691798378_252809">-Evan</span></div>
<div class="yiv8444884465MsoNormal"
id="yui_3_16_0_1_1440691798378_252262"><span
style="font-size: 12pt;"> </span></div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>