[Swift-devel] DataNode.toString()

[Justin M Wozniak]

I think we do want the old behavior for trace().  I can update tracef().

On Wed, 25 May 2011, Mihael Hategan wrote:

> data.toString() had this hack that if there was a value, it would return
> that value (which was assumed useable in fuctional code), otherwise it
> would return the cryptic stuff.
>
> So depending on whether we want the old behavior or not is trace and
> tracef, I can add a .getValue() where needed.
>
> So do we?
>
> Mihael
>
> On Wed, 2011-05-25 at 14:53 -0500, Justin M Wozniak wrote:
>> Ok, just so we're all on the same page:
>>
>> trace("hi", "all");
>>
>> used to say:
>>
>> SwiftScript trace: hi, all
>>
>> now says:
>>
>> SwiftScript trace: ?:string = hi - Closed, ?:string = all - Closed
>>
>> On Wed, 25 May 2011, Mihael Hategan wrote:
>>
>>> On Wed, 2011-05-25 at 13:20 -0500, Justin M Wozniak wrote:
>>>> This also affects the behavior of trace().
>>>
>>> Yes. That was the intent. Removing the noise from swiftData.toString().
>>>
>>>>   Might it impact other Swift
>>>> functionality like mappers?
>>>
>>> I don't think so, but if you can think of a specific scenario, I'm
>>> listening.
>>>
>>>>
>>>> On Tue, 17 May 2011, Mihael Hategan wrote:
>>>>
>>>>> Indeed. I committed a fix to unwrap swift data when passing values to
>>>>> execute() (stdin, out, err, and the arguments in particular).
>>>>>
>>>>> I don't think toString() should be "overloaded" like it was.
>>>>>
>>>>>
>>>>> On Tue, 2011-05-17 at 16:56 -0500, Justin M Wozniak wrote:
>>>>>> I think this change affects arguments to apps:
>>>>>>
>>>>>> type file;
>>>>>>
>>>>>> (file f) echo (int i) {
>>>>>> app { echo i stdout=@f; }
>>>>>> }
>>>>>>
>>>>>> int greetings = 2;
>>>>>> file hw = echo(greetings);
>>>>>>
>>>>>> ------>
>>>>>>
>>>>>> DEBUG vdl:execute2 JOB_START jobid=echo-tnyfi9ak tr=echo
>>>>>> arguments=[greetings:int = 2.0 - Closed]
>>>>>> ...
>>>>>>
>>>>>> On Fri, 13 May 2011, Mihael Hategan wrote:
>>>>>>
>>>>>>> I changed that in trunk. It used to be:
>>>>>>>
>>>>>>> org.griphyn.vdl.mapping.RootDataNode identifier
>>>>>>> dataset:20110512-2343-5rl3b7x5:720000000072 type Sgt with no value at
>>>>>>> dataset=sgt_var (not closed)
>>>>>>>
>>>>>>> That was annoying, noisy, and I had no idea what's what.
>>>>>>>
>>>>>>> It is now:
>>>>>>>
>>>>>>> name:type = value - [Open/Closed]
>>>>>>>
>>>>>>> The provenance data should still be the same, but it may not. So please
>>>>>>> let me know if anything breaks.
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Swift-devel mailing list
>>>>>>> Swift-devel at ci.uchicago.edu
>>>>>>> http://mail.ci.uchicago.edu/mailman/listinfo/swift-devel
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>
>
>
>
>

-- 
Justin M Wozniak