[petsc-dev] Master broken after changes to PetscSection headers

[Smith, Barry F.]

  Master is already broken so you might as well merge since you can't break it more than I did.

  Barry


> On Sep 19, 2019, at 4:48 PM, Zhang, Junchao via petsc-dev <petsc-dev at mcs.anl.gov> wrote:
> 
> Could this problem be fixed right now? It shows up in stage-1 tests and block further tests.
> 
> --Junchao Zhang
> 
> 
> On Thu, Sep 19, 2019 at 4:15 AM Lisandro Dalcin via petsc-dev <petsc-dev at mcs.anl.gov> wrote:
> The warnings below are from a C build. A C++ build fails right away.
> 
> We need to `#include <petscsection.h>` somewhere in the public headers, at least such that  `#include <petsc.h>` in user code works.
> 
> $ git grep petscsection include/
> include/petsc/private/sectionimpl.h:#include <petscsection.h>
> include/petscis.h:#include <petscsectiontypes.h>
> include/petscsection.h:#include <petscsectiontypes.h>
> 
> 
> /home/devel/petsc/dev/src/snes/utils/convest.c: In function ‘PetscConvEstGetConvRate’:
> /home/devel/petsc/dev/src/snes/utils/convest.c:293:14: warning: implicit declaration of function ‘PetscSectionGetField’; did you mean ‘PetscSectionVecView’? [-Wimplicit-function-declaration]
>   293 |       ierr = PetscSectionGetField(s, f, &fs);CHKERRQ(ierr);
>       |              ^~~~~~~~~~~~~~~~~~~~
>       |              PetscSectionVecView
> /home/devel/petsc/dev/src/snes/utils/convest.c:294:14: warning: implicit declaration of function ‘PetscSectionGetConstrainedStorageSize’ [-Wimplicit-function-declaration]
>   294 |       ierr = PetscSectionGetConstrainedStorageSize(fs, &lsize);CHKERRQ(ierr);
>       |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> -- 
> Lisandro Dalcin
> ============
> Research Scientist
> Extreme Computing Research Center (ECRC)
> King Abdullah University of Science and Technology (KAUST)
> http://ecrc.kaust.edu.sa/