[petsc-dev] Missing typedef ?

[Smith, Barry F.]

> On Jan 28, 2018, at 10:50 AM, Franck Houssen <franck.houssen at inria.fr> wrote:
> 
> Hello,
> 
> In petscmat.h, the line "#define MatSolverPackage char*" shouldn't it be replaced with "typedef char* MatSolverPackage" ? (like it's done for MatType and others)

  You are correct.

> 
> When trying to use MatSolverPackage from a cpp file where "petsc.h" and "petscmat.h" have been included I get this error : error: ‘MatSolverPackage’ does not name a type; did you mean ‘MatSolverType’?.
> Looks like this error does occur, or not, depending on compiler / OS : this is OK with debian but not with ubuntu-trusty (line 2191 here https://travis-ci.org/fghoussen/geneo4PETSc/jobs/334384582).
> I would say the compile error can occur, or not, according to what -fvisibility defaults to.


   Unfortunately I cannot make the fix in maint because it will cause a large number of conflicts with master (I tried) so I can only do the fix in master and as Jose notes also in master it is now MatSolverType.

   Thanks for reporting the issue,

   Barry

> 
> Not sure of this...
> 
> Franck