[petsc-dev] #if 0 stuff in source code

Dominic Meiser dmeiser at txcorp.com
Wed Jun 25 09:25:41 CDT 2014


I noticed the commented out code as well and wasn't sure whether it 
could be removed. I agree with Karl, it can go.

Karl, I can deal with this in a new branch to not confuse things with 
the current pull request. I think this will merge rather easily down the 
road.

Cheers,
Dominic


On 06/25/2014 01:33 AM, Karl Rupp wrote:
> Hi,
>
> >      There is a bunch of #if 0  droplets in the source code related 
> to the use of CUSP. Can all that be removed? It isn’t good to have 
> dead code like that in source. It’s ugly and confusing.
>
> Most of this is in the code base for at least 1.5 years now (it was 
> there when I first looked at it), so I think it can be removed as it 
> hasn't been needed in any way. However, I'd like to deal with 
> Dominic's pull request first in order not to make the merge more 
> painful than necessary.
>
> Best regards,
> Karli
>


-- 
Dominic Meiser
Tech-X Corporation
5621 Arapahoe Avenue
Boulder, CO 80303
USA
Telephone: 303-996-2036
Fax: 303-448-7756
www.txcorp.com




More information about the petsc-dev mailing list