[petsc-dev] #if 0 stuff in source code

[Karl Rupp]

Hey,

 > I noticed the commented out code as well and wasn't sure whether it
> could be removed. I agree with Karl, it can go.
>
> Karl, I can deal with this in a new branch to not confuse things with
> the current pull request. I think this will merge rather easily down the
> road.

fine with me - you've got a better overview of the changes you applied. 
I assume that haven't got any changes in the "#if 0"-code sections 
anyway ;-)

Best regards,
Karli



>
> On 06/25/2014 01:33 AM, Karl Rupp wrote:
>> Hi,
>>
>> >      There is a bunch of #if 0  droplets in the source code related
>> to the use of CUSP. Can all that be removed? It isn’t good to have
>> dead code like that in source. It’s ugly and confusing.
>>
>> Most of this is in the code base for at least 1.5 years now (it was
>> there when I first looked at it), so I think it can be removed as it
>> hasn't been needed in any way. However, I'd like to deal with
>> Dominic's pull request first in order not to make the merge more
>> painful than necessary.
>>
>> Best regards,
>> Karli
>>
>
>