[petsc-dev] Matt, please don't put buggy code into PETSc

[Jed Brown]

Matthew Knepley <knepley at gmail.com> writes:

> On Sun, Jan 19, 2014 at 6:42 PM, Jed Brown <jed at jedbrown.org> wrote:
>
>> Matthew Knepley <knepley at gmail.com> writes:
>> > Yes, I am aware, and as I pointed out, I was checking the complex build,
>>
>> You didn't mention "complex" in this thread, just something about C
>> typedefs which isn't true because you get warnings like this in C.
>>
>> warning: incompatible pointer types passing 'PetscScalar *' (aka '_Complex
>> double *') to parameter of type 'PetscReal *' (aka 'double *')
>> [-Wincompatible-pointer-types]
>>     ierr = VecNorm(Z,NORM_2,&dp);CHKERRQ(ierr);                /*    dp <-
>> z'*z = e'*A'*B'*B*A'*e'     */
>>                             ^
>
>
> I obviously do not get this warning.

What compiler?  Both gcc and clang warn.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20140119/1dda9d28/attachment.sig>