[petsc-dev] Matt, please don't put buggy code into PETSc

[Matthew Knepley]

On Sun, Jan 19, 2014 at 7:00 PM, Jed Brown <jed at jedbrown.org> wrote:

> Matthew Knepley <knepley at gmail.com> writes:
>
> > On Sun, Jan 19, 2014 at 6:42 PM, Jed Brown <jed at jedbrown.org> wrote:
> >
> >> Matthew Knepley <knepley at gmail.com> writes:
> >> > Yes, I am aware, and as I pointed out, I was checking the complex
> build,
> >>
> >> You didn't mention "complex" in this thread, just something about C
> >> typedefs which isn't true because you get warnings like this in C.
> >>
> >> warning: incompatible pointer types passing 'PetscScalar *' (aka
> '_Complex
> >> double *') to parameter of type 'PetscReal *' (aka 'double *')
> >> [-Wincompatible-pointer-types]
> >>     ierr = VecNorm(Z,NORM_2,&dp);CHKERRQ(ierr);                /*    dp
> <-
> >> z'*z = e'*A'*B'*B*A'*e'     */
> >>                             ^
> >
> >
> > I obviously do not get this warning.
>
> What compiler?  Both gcc and clang warn.
>

I can't believe you are interested:

i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
Copyright (C) 2007 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

   Matt

-- 
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which their
experiments lead.
-- Norbert Wiener
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20140119/92c74c27/attachment.html>