[petsc-dev] pushing to next fails

[Stefano Zampini]

I removed the trailing whitespaces

https://bitbucket.org/petsc/petsc/commits/5dd13310d584c8104eddeeabd0df18eb55b5a3f9?at=stefano_zampini/pcbddc-reusebddc

and added the precommit hook, but still I get the same error from git push.

I cannot understand where my code is not conforming since the pre-receive
hook is not verbosed enough.

I read your comments and replied. See also

https://bitbucket.org/petsc/petsc/commits/165b64e2ecb4f5abc326a9d4c71cd3217b80ea8d?at=stefano_zampini/pcbddc-reusebddc




2013/11/5 Jed Brown <jedbrown at mcs.anl.gov>

> Stefano Zampini <s.zampini at cineca.it> writes:
>
> > I'm having troubles while pushing to next. On my working copy, I only
> > merged stefano_zampini/pcbddc-reusebddc
>
> This is a result of turning on branch restrictions, which makes it less
> stressful to hand out commit access to collaborators.
>
> http://mail-archive.com/search?l=mid&q=871u3f1cuk.fsf@mcs.anl.gov
>
>
>
> I made some comments in your branch.  I'm not a fan of the deep comparison
> in
>
>
> https://bitbucket.org/petsc/petsc/commits/f4ddd8eecafc09061839cfbaf2bc8c47641ebc86
>
> Your branch also adds trailing whitespace in a number of places.  You
> can use "git diff --check" to have it show you bad whitespace or you can
> enable a precommit hook to check.  The sample does this, so this is
> sufficient.
>
>   $ git mv .git/hooks/pre-commit.sample .git/hooks/pre-commit
>



-- 

Ph. D. Stefano Zampini
CINECA
SuperComputing Applications and Innovations Department - SCAI
Via dei Tizii, 6 00185 Roma - ITALY
------------------------------------------------------------------------------------------------------------------------
Email: s.zampini at cineca.it
SkypeID: stefano.zampini
GoogleTalk: stefano.zampini at gmail.com
Tel: +39 06.44486.707
------------------------------------------------------------------------------------------------------------------------
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20131105/05b76184/attachment.html>