[petsc-dev] naming of DM specific constructors is backwards

[Dmitry Karpeev]

On Thu, Sep 13, 2012 at 9:12 PM, Jed Brown <jedbrown at mcs.anl.gov> wrote:

> Constructor tab completion is better for DMCreateDA().
>
But will clash with all the other methods of the form DMDAGetXXX() etc.
I would vote for converting MatCreateSeqAIJ to MatSeqAIJCreate().
Note also that Mat*Create will Tab-expand to all possible Mat constructors
in an emacs tag search.

Dmitry.



>  On Sep 13, 2012 9:05 PM, "Barry Smith" <bsmith at mcs.anl.gov> wrote:
>
>>
>>    MatCreateSeqAIJ()  etc etc etc
>>
>>     but
>>
>>     DMDACreate(), DMRedundantCreate() etc
>>
>>
>>     Now given that normally we list the subclass name right after the
>> base class in methods, for example KSPGMRESSetRestart() not
>> KSPSetRestartGMRES() it might make sense to always follow the DMXXXCreate()
>> style and change ALL the other sub constructor names to the DM style. Boy I
>> know Wolfgang will not be happy with that :-)
>>
>>     Should we just fix the DM sub constructors to follow the style of all
>> the other ones?
>>
>>     Barry
>>
>>
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120913/436f1f89/attachment.html>