[petsc-dev] naming of DM specific constructors is backwards

Barry Smith bsmith at mcs.anl.gov
Thu Sep 13 22:15:35 CDT 2012


On Sep 13, 2012, at 9:25 PM, Dmitry Karpeev <karpeev at mcs.anl.gov> wrote:

> 
> 
> On Thu, Sep 13, 2012 at 9:12 PM, Jed Brown <jedbrown at mcs.anl.gov> wrote:
> Constructor tab completion is better for DMCreateDA().
> 
> But will clash with all the other methods of the form DMDAGetXXX() etc.
> I would vote for converting MatCreateSeqAIJ to MatSeqAIJCreate().

   We'll assign you to listen to the ten minute rant from Wolfgang then :-)

 
> Note also that Mat*Create will Tab-expand to all possible Mat constructors in an emacs tag search.
> 
> Dmitry.
> 
>  
> On Sep 13, 2012 9:05 PM, "Barry Smith" <bsmith at mcs.anl.gov> wrote:
> 
>    MatCreateSeqAIJ()  etc etc etc
> 
>     but
> 
>     DMDACreate(), DMRedundantCreate() etc
> 
> 
>     Now given that normally we list the subclass name right after the base class in methods, for example KSPGMRESSetRestart() not KSPSetRestartGMRES() it might make sense to always follow the DMXXXCreate() style and change ALL the other sub constructor names to the DM style. Boy I know Wolfgang will not be happy with that :-)
> 
>     Should we just fix the DM sub constructors to follow the style of all the other ones?
> 
>     Barry
> 
> 
> 
>    
> 




More information about the petsc-dev mailing list