[petsc-dev] Binary test files in $PETSC_DIR/include ?

[Barry Smith]

On Sep 5, 2011, at 10:36 PM, Lisandro Dalcin wrote:

> On 5 September 2011 22:56, Barry Smith <bsmith at mcs.anl.gov> wrote:
>> 
>> On Sep 5, 2011, at 8:52 PM, Lisandro Dalcin wrote:
>> 
>>> Barry, did you really meant to add these files in $PETSC_DIR/include ?
>> 
>>  Yes, is this a problem?
>> 
> 
> Well, I usually think of */include as a place to put header files.

  I'm happy to put them some other "standard" place if there is such a thing. I stuck them in include because that contains non-generated stuff while lib contains generated stuff.

   Barry

> 
>>   Where are you getting them listed as changed?  They should never be changed.
>> 
> 
> No, no.. Just wanted to make sure these files were not added (in that
> place) by mistake.
> 
>>> 
>>> [dalcinl at trantor petsc-3.2]$ hg show paths.default
>>> ssh://petsc@petsc.cs.iit.edu//hg/petsc/releases/petsc-3.2
>>> 
>>> [dalcinl at trantor petsc-3.2]$ hg log -p include/datafiles/matrices/
>>> changeset:   20128:497567453eac
>>> parent:      20118:944e41e7f798
>>> user:        Barry Smith <bsmith at mcs.anl.gov>
>>> date:        Mon Aug 29 20:49:00 2011 -0500
>>> summary:     added test files
>>> 
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/hpd-complex-int32-float32
>>> Binary file include/datafiles/matrices/hpd-complex-int32-float32 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/hpd-complex-int32-float64
>>> Binary file include/datafiles/matrices/hpd-complex-int32-float64 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/hpd-complex-int64-float32
>>> Binary file include/datafiles/matrices/hpd-complex-int64-float32 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/hpd-complex-int64-float64
>>> Binary file include/datafiles/matrices/hpd-complex-int64-float64 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/nh-complex-int32-float32
>>> Binary file include/datafiles/matrices/nh-complex-int32-float32 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/nh-complex-int32-float64
>>> Binary file include/datafiles/matrices/nh-complex-int32-float64 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/nh-complex-int64-float32
>>> Binary file include/datafiles/matrices/nh-complex-int64-float32 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/nh-complex-int64-float64
>>> Binary file include/datafiles/matrices/nh-complex-int64-float64 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/ns-real-int32-float32
>>> Binary file include/datafiles/matrices/ns-real-int32-float32 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/ns-real-int32-float64
>>> Binary file include/datafiles/matrices/ns-real-int32-float64 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/ns-real-int64-float32
>>> Binary file include/datafiles/matrices/ns-real-int64-float32 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/ns-real-int64-float64
>>> Binary file include/datafiles/matrices/ns-real-int64-float64 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/spd-real-int32-float32
>>> Binary file include/datafiles/matrices/spd-real-int32-float32 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/spd-real-int32-float64
>>> Binary file include/datafiles/matrices/spd-real-int32-float64 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/spd-real-int64-float32
>>> Binary file include/datafiles/matrices/spd-real-int64-float32 has changed
>>> diff -r 944e41e7f798 -r 497567453eac
>>> include/datafiles/matrices/spd-real-int64-float64
>>> Binary file include/datafiles/matrices/spd-real-int64-float64 has changed
>>> 
>>> 
>>> --
>>> Lisandro Dalcin
>>> ---------------
>>> CIMEC (INTEC/CONICET-UNL)
>>> Predio CONICET-Santa Fe
>>> Colectora RN 168 Km 472, Paraje El Pozo
>>> 3000 Santa Fe, Argentina
>>> Tel: +54-342-4511594 (ext 1011)
>>> Tel/Fax: +54-342-4511169
>> 
>> 
> 
> 
> 
> -- 
> Lisandro Dalcin
> ---------------
> CIMEC (INTEC/CONICET-UNL)
> Predio CONICET-Santa Fe
> Colectora RN 168 Km 472, Paraje El Pozo
> 3000 Santa Fe, Argentina
> Tel: +54-342-4511594 (ext 1011)
> Tel/Fax: +54-342-4511169