[MOAB-dev] DAGMC HDF5 Issues

[Vijay S. Mahadevan]

Paul,

I think we definitely need to enforce running: "make check", before
all commits and I think it is fair to just perform the other tests
before merging/approving a pull request. We run "make dist distcheck"
in the buildbot tests daily and so our regular configurations should
be tested nightly anyway.

Vijay

On Thu, Mar 27, 2014 at 12:48 PM, Paul Wilson <wilsonp at engr.wisc.edu> wrote:
> Hi Andy,
>
> I think I learned that we need to run more tests before we push:
>
> make check
> make dist
> make distcheck
>
> The last of these is important (and nominally a superset of the first 2) and
> makes sure that tests pass from a tarball, not just from the repo.
>
>
> Paul
>
> On 03/27/2014 12:23 PM, Andrew Davis wrote:
>
> HI Iulian
>
> Just tried them thanks works great. Is there a source of documentation that
> would have described the process to adding those things? I tried and failed
> miserably at this end.
>
> Andy
>
>
> On 03/27/2014 12:14 PM, Grindeanu, Iulian R. wrote:
>
> I think I fixed those, you should git pull and try.
>
> (I modified dagmc/Makefile.am )
>
>
> ________________________________
> From: moab-dev-bounces at mcs.anl.gov [moab-dev-bounces at mcs.anl.gov] on behalf
> of Andrew Davis [davisa at engr.wisc.edu]
> Sent: Thursday, March 27, 2014 11:50 AM
> To: moab-dev at mcs.anl.gov
> Subject: [MOAB-dev] DAGMC HDF5 Issues
>
>     Ive added the lines
>          dagmc/dagmc_rayfire_test \
>          dagmc/dagmc_simple_test \
>          dagmc/dagmc_pointinvol_test
>     (I also tried without the starting dagmc/)
>     to if HDF5_FILE in Makefile.am in /test/
>     I also added the h5m file we require MeshFiles/unittest/Makefile.am
>     I then build build without hdf5, and the test still run.
>     Could you please clarify that these are the correct locations for these
>     files
>     Thanks
>     Andy
>
>
>
> --
> -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ --
> Paul Wilson ~ UW-Madison ~ 608-263-0807 ~ cal: http://bit.ly/pphw-cal
> Professor, Engineering Physics. ~ http://cnerg.engr.wisc.edu
> Faculty Director, Advanced Computing Infrastructure