[MOAB-dev] commit/MOAB: danwu: Users might create more than one file set to read the same file. The tag values of dummy dimension variables should be set for every file set. Thanks to Jayesh for finding this bug.

[commits-noreply at bitbucket.org]

1 new commit in MOAB:

https://bitbucket.org/fathomteam/moab/commits/f46c68e8b859/
Changeset:   f46c68e8b859
Branch:      master
User:        danwu
Date:        2013-11-22 18:21:25
Summary:     Users might create more than one file set to read the same file. The tag values of dummy dimension variables should be set for every file set. Thanks to Jayesh for finding this bug.

Affected #:  1 file

diff --git a/src/io/NCHelper.cpp b/src/io/NCHelper.cpp
index bb6d689..6c48d44 100644
--- a/src/io/NCHelper.cpp
+++ b/src/io/NCHelper.cpp
@@ -749,11 +749,8 @@ ErrorCode NCHelper::create_dummy_variables()
 
     // Create a corresponding sparse tag
     Tag tagh;
-    ErrorCode rval = mbImpl->tag_get_handle(dimNames[i].c_str(), 0, MB_TYPE_INTEGER, tagh, MB_TAG_CREAT |
-                                            MB_TAG_SPARSE | MB_TAG_VARLEN | MB_TAG_EXCL);
-    // If the tag already exists, skip
-    if (MB_ALREADY_ALLOCATED == rval)
-      continue;
+    ErrorCode rval = mbImpl->tag_get_handle(dimNames[i].c_str(), 0, MB_TYPE_INTEGER, tagh,
+                                            MB_TAG_CREAT | MB_TAG_SPARSE | MB_TAG_VARLEN);
     ERRORR(rval, "Failed to create tag for a dummy dimension variable.");
 
     // Tag value is the dimension length

Repository URL: https://bitbucket.org/fathomteam/moab/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.