[MOAB-dev] r4696 - MOAB/trunk/src/io

[Steve Jackson]

Amendment: I have one .sat model that still doesn't work with the latest sense fixes.  The ReadCGM process gets into trouble at GeomTopoTool.cpp, line 612.

Iulian, is this something you could look at?  The affected model is on the large side (2.4 mb as a tarball), so if you're able to investigate, I can email it directly to you.
~S


On Mar 31, 2011, at 10:50 , Steve Jackson wrote:

> R4696 seems to fix the problem, and DagMC is working again.  Thank you for such a quick fix, Iulian! 
> ~S
> 
> On Mar 30, 2011, at 22:00 , Iulian Grindeanu wrote:
> 
>> Hi Steve,
>> Can you please check if this fixes dagmc?
>> I am not sure ...
>> 
>> Thanks,
>> Iulian
>> 
>> ----- Forwarded Message -----
>>> Author: iulian
>>> Date: 2011-03-30 21:58:48 -0500 (Wed, 30 Mar 2011)
>>> New Revision: 4696
>>> 
>>> Modified:
>>> MOAB/trunk/src/io/ReadCGM.cpp
>>> Log:
>>> the convention for senses is now changed: +1 is forward, -1 is
>>> reverse,
>>> 0 is both senses
>>> 
>>> 
>>> 
>>> Modified: MOAB/trunk/src/io/ReadCGM.cpp
>>> ===================================================================
>>> --- MOAB/trunk/src/io/ReadCGM.cpp 2011-03-30 22:46:58 UTC (rev 4695)
>>> +++ MOAB/trunk/src/io/ReadCGM.cpp 2011-03-31 02:58:48 UTC (rev 4696)
>>> @@ -273,12 +273,12 @@
>>> }
>>> 
>>> if (forward) {
>>> - rval = myGeomTool->set_sense( ci->second, entmap[3][forward], true
>>> );
>>> + rval = myGeomTool->set_sense( ci->second, entmap[3][forward], 1 );
>>> if (MB_SUCCESS != rval)
>>> return rval;
>>> }
>>> if (reverse) {
>>> - rval = myGeomTool->set_sense( ci->second, entmap[3][reverse], false
>>> );
>>> + rval = myGeomTool->set_sense( ci->second, entmap[3][reverse], -1 );
>>> if (MB_SUCCESS != rval)
>>> return rval;
>>> }
>>> @@ -298,12 +298,12 @@
>>> if (ce->get_sense() == CUBIT_UNKNOWN ||
>>> ce->get_sense() != edge->get_curve_ptr()->bridge_sense()) {
>>> ents.push_back(face);
>>> - senses.push_back(CUBIT_REVERSED);
>>> + senses.push_back(-1);
>>> }
>>> if (ce->get_sense() == CUBIT_UNKNOWN ||
>>> ce->get_sense() == edge->get_curve_ptr()->bridge_sense()) {
>>> ents.push_back(face);
>>> - senses.push_back(CUBIT_FORWARD);
>>> + senses.push_back(1);
>>> }
>>> }
>