[petsc-dev] petsc4py doc problem

Barry Smith bsmith at petsc.dev
Wed Jun 28 00:08:45 CDT 2023


  Generally, I like Python a great deal and think Python developers make good decisions, but their love of the 80-character limit is absurdly out of character and so fundamentally wrong.

> On Jun 28, 2023, at 1:03 AM, Satish Balay via petsc-dev <petsc-dev at mcs.anl.gov> wrote:
> 
>>>>>>>>> 
> https://gitlab.com/petsc/petsc/-/merge_requests/6578/commits
> 
> commit 0898713fbecf5e265dbd1d072d2bffc3dcf92948
> Author: Stefano Zampini <stefano.zampini at gmail.com>
> Date:   Sat Jun 17 20:40:28 2023 +0200
> 
>    petsc4py docs: enforce 79 characters lines
> <<<<<<<<<<<
> 
> so perhaps:
> 
> diff --git a/src/binding/petsc4py/src/petsc4py/PETSc/Mat.pyx b/src/binding/petsc4py/src/petsc4py/PETSc/Mat.pyx
> index 067d98e3b0b..c04f501c73b 100644
> --- a/src/binding/petsc4py/src/petsc4py/PETSc/Mat.pyx
> +++ b/src/binding/petsc4py/src/petsc4py/PETSc/Mat.pyx
> @@ -4745,7 +4745,8 @@ cdef class Mat(Object):
>         U : Mat
>             The first dense rectangular matrix.
>         c : Vec
> -            The sequential vector containing the diagonal of ``C``, or NULL for all ones.
> +            The sequential vector containing the diagonal of ``C``,
> +            or NULL for all ones.
>         V : Mat
>             The second dense rectangular matrix, or NULL for a copy of ``U``.
> 
> Satish
> 
> 
> On Tue, 27 Jun 2023, Matthew Knepley wrote:
> 
>> I do not understand those docs at all:
>> 
>> Using PETSC inventory from
>> file:///scratch/svcpetsc/glci-builds-stage2/VW-hbPim/0/petsc/petsc/public/html/objects.inv
>> <Inventory (url): PETSc vv3.19.2-597-g38258f1efa0, 7486 objects>
>> Warning, treated as error:
>> Line 9 for Mat.setLRCMats(self, A: Mat, U: Mat, c: Vec | None = None, V:
>> Mat | None = None) too long.
>> 
>>  https://gitlab.com/petsc/petsc/-/jobs/4554950030
>> 
>> Can someone fix this? https://gitlab.com/petsc/petsc/-/merge_requests/6640
>> 
>>  Thanks,
>> 
>>     Matt
>> 
>> 
> 



More information about the petsc-dev mailing list