[petsc-dev] Configure push

Matthew Knepley knepley at gmail.com
Mon Jun 6 16:44:27 CDT 2016


On Mon, Jun 6, 2016 at 7:08 PM, Satish Balay <balay at mcs.anl.gov> wrote:

> On Mon, 6 Jun 2016, Matthew Knepley wrote:
>
> > On Mon, Jun 6, 2016 at 5:27 PM, Satish Balay <balay at mcs.anl.gov> wrote:
> >
> > > Matt,
> > >
> > > Per integration workflow - all feature branches should be tested
> > > locally (and be complete) - before merged to next [next is for
> > > integration testing - not feature testing]
> > >
> > > You could have used (modified):
> > >
> > > config/examples/arch-linux-xsdk-dbg.py
> > > config/examples/arch-osx-xsdk-opt.py
> > >
> > > Yeah - we don't have automatic 'feature branch test before integration
> > > testing' workflow - so currently this has to be done manually.
> >
> >
> > I don't really have the OS/compiler options available to test things
> > exhaustively, so I am
> > using next for this. I think this is acceptable right now.
>
> Well then the feature is not yet ready for next - and could have
> waited until it was ready.
>

I do nto agree here. Just because some Git nerd thinks that 'next' should be
that way does not mean it is what makes us most productive. I think we are
way
more productive using the nightly tests as a way to discover bugs. I cannot
waste
my personal time running a bunch of tests on my own slow laptop before
pushing.

  Matt


> If it was for someone to use - then they could have used the
> feature-branch..
>
> The workflow requires the feature to be complete - and minimally
> tested - before merge to next.. We do ocassionally take shortcuts -
> but this sometimes this results in extended broken next...
>
> Satish
>
>
>


-- 
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which their
experiments lead.
-- Norbert Wiener
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20160606/7bc0af05/attachment.html>


More information about the petsc-dev mailing list