[petsc-dev] Use of PETSC_DEFAULT in Chaco interface

Jed Brown jedbrown at mcs.anl.gov
Sat Feb 2 15:06:38 CST 2013


/home/jed/petsc/src/mat/partition/impls/chaco/chaco.c:484:13: warning:
comparison of constant -2 with expression of type 'MPChacoEigenType' is
always false [-Wtautological-c
onstant-out-of-range-compare]
  if (method==PETSC_DEFAULT) chaco->eigen_method = MP_CHACO_LANCZOS;
      ~~~~~~^ ~~~~~~~~~~~~~

Meanwhile, we have

typedef enum { MP_CHACO_LANCZOS=0,MP_CHACO_RQI=1 } MPChacoEigenType;

Either we add a typed MP_CHACO_DEFAULT to the enum or we get rid of the
concept of PETSC_DEFAULT in that context. Which is it?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20130202/a725d61c/attachment.html>


More information about the petsc-dev mailing list