[petsc-dev] Use of PETSC_DEFAULT in Chaco interface

[Karl Rupp]

Hi Jed,

I consider adding MP_CHACO_DEFAULT more appropriate and allowing 
PETSC_DEFAULT as a 'generic' option. I don't know how this is handled in 
other subpackages, though...

Best regards,
Karli

On 02/02/2013 03:06 PM, Jed Brown wrote:
> /home/jed/petsc/src/mat/partition/impls/chaco/chaco.c:484:13: warning:
> comparison of constant -2 with expression of type 'MPChacoEigenType' is
> always false [-Wtautological-c
> onstant-out-of-range-compare]
>    if (method==PETSC_DEFAULT) chaco->eigen_method = MP_CHACO_LANCZOS;
>        ~~~~~~^ ~~~~~~~~~~~~~
>
> Meanwhile, we have
>
> typedef enum { MP_CHACO_LANCZOS=0,MP_CHACO_RQI=1 } MPChacoEigenType;
>
> Either we add a typed MP_CHACO_DEFAULT to the enum or we get rid of the
> concept of PETSC_DEFAULT in that context. Which is it?