[Swift-devel] Please verify 0.92 checkout & build instructions

[Mihael Hategan]

So now for the mystery of why this patch didn't make it to trunk in the
merge: the quoting methods were extracted in an abstract class. They
were overridden in the condor executor, but I thought that was just a
consequence of the refactoring, so I removed that code.

The truth was somewhere in the middle: the abstract replaceVars is ok,
but not the abstract quote() which needs to be made more specific for
condor.

Mihael

On Thu, 2011-01-13 at 12:43 -0600, Michael Wilde wrote:
> OK, that *seems* to work. The argument string is now:
> 
> arguments = /osg/data/engage/tmp/ce02.cmsaf.mit.edu/catsn-20110113-1240-vn86uhoc/shared/_swiftwrap cat-jaxfbf4k -jobdir j -scratch \"\" -e /bin/cat -out outdir/f.0001.out -err stderr.txt -i -d outdir -if data.txt -of outdir/f.0001.out -k \"\" -cdmfile \"\" -status file -a data.txt
> 
> with \"\" for empty args.
> 
> Im going to commit this and test, then get a build of trunk to Marc.
> 
> Sarah, how/when do you want this and other fixes committed to the 0.92 branch?
> Do you want to do these mods?
> 
> - Mike
> 
> 
> ----- Original Message -----
> > OK. I think the behavior Im seeing is due to 2 errors:
> > 
> > - the new quote logic (from Ben) was (inadvertently, I think) dropped
> > out of trunk at rev 2989
> > 
> > - the new quote logic itself has an error, in that instead of quoting
> > a zero-length argument as \"\" it instead inserts nothing into the
> > arguments= line for this case. For the examples Ive seen, this *seems*
> > to cause no harm, and was enabling jobs to run. I think its incorrect,
> > though.
> > 
> > I will put this back in trunk, test on Condor-G, and report back.
> > 
> > - Mike
> > 
> > 
> > ----- Original Message -----
> > > On Thu, 2011-01-13 at 11:37 -0600, Michael Wilde wrote:
> > > > I updated the ReleasePlans page with the checkout procedure that I
> > > > used.
> > > >   http://www.ci.uchicago.edu/wiki/bin/view/SWFT/ReleasePlans
> > > >
> > > > Could everyone verify that this is correct:
> > > >
> > > > svn co
> > > > https://cogkit.svn.sourceforge.net/svnroot/cogkit/branches/4.1.8/src/cog
> > > > cd cog/modules
> > > > svn co https://svn.ci.uchicago.edu/svn/vdl2/branches/release-0.92
> > > > swift
> > > > cd swift
> > > > ant redist
> > >
> > > This is correct.
> > 
> > --
> > Michael Wilde
> > Computation Institute, University of Chicago
> > Mathematics and Computer Science Division
> > Argonne National Laboratory
> > 
> > _______________________________________________
> > Swift-devel mailing list
> > Swift-devel at ci.uchicago.edu
> > http://mail.ci.uchicago.edu/mailman/listinfo/swift-devel
>