[petsc-dev] tests coverage

[Barry Smith]

  The MR was almost perfect. Then we switched from launching pipelines directly to doing them through the MR, which changed the way some of the information was formatted. We should wire this up properly and then require MR not to introduce new lines of untested code. It has been on my to-do list for a very long time. Not terribly difficult, just requires the perfect alignment of the stars to get working perfectly.



  Barry


> On Aug 12, 2022, at 1:27 PM, Satish Balay via petsc-dev <petsc-dev at mcs.anl.gov> wrote:
> 
> I think there is some logic there that marks only the lines from the MR diff. Barry might remember this correctly.
> 
> Satish
> 
> On Fri, 12 Aug 2022, Blaise Bourdin wrote:
> 
>> thanks Satish,
>> 
>> That doesn’t seem quite right, though. For instance, I see that https://petsc.gitlab.io/-/petsc/-/jobs/2841119765/artifacts/arch-ci-analyze-pipeline/index_gcov.html reports only 30 testable lines in
>> plexexodusii.c, none of which are tested, while I know that there are much more than that, and that most of them are indeed tested.
>> Regards,
>> Blaise
>> 
>>      On Aug 12, 2022, at 11:37 AM, Satish Balay <balay at mcs.anl.gov> wrote:
>> 
>> There is some coverage info - there are a couple of gcov tests - but
>> that doesn't show coverage from all tests.
>> 
>> For ex: https://gitlab.com/petsc/petsc/-/merge_requests/5509
>> 
>> click on the last stage/job of the pipeline 'analyze-pipeline' i.e
>> https://gitlab.com/petsc/petsc/-/jobs/2841119765
>> 
>> Here - browse 'artifacts' i.e
>> https://gitlab.com/petsc/petsc/-/jobs/2841119765/artifacts/browse
>> 
>> Here go to 'arch-ci-analyze-pipeline' and click 'index_gcov.html' i.e:
>> https://petsc.gitlab.io/-/petsc/-/jobs/2841119765/artifacts/arch-ci-analyze-pipeline/index_gcov.html
>> 
>> Satish
>> 
>> On Fri, 12 Aug 2022, Blaise Bourdin wrote:
>> 
>>      Hi,
>> 
>>      Is the source coverage analysis by the tests easily available? When submitting a MR, I want to know if adding a test is necessary.
>> 
>>      Regards,
>>      Blaise
>> 
>> 
>>      —
>>      Tier 1 Canada Research Chair in Mathematical and Computational Aspects of Solid Mechanics
>>      Professor, Department of Mathematics & Statistics
>>      Hamilton Hall room 409A, McMaster University
>>      1280 Main Street West, Hamilton, Ontario L8S 4K1, Canada
>>      https://www.math.mcmaster.ca/bourdin | +1 (905) 525 9140 ext. 27243
>> 
>> 
>> 
>> — 
>> Tier 1 Canada Research Chair in Mathematical and Computational Aspects of Solid Mechanics
>> Professor, Department of Mathematics & Statistics
>> Hamilton Hall room 409A, McMaster University
>> 1280 Main Street West, Hamilton, Ontario L8S 4K1, Canada 
>> https://www.math.mcmaster.ca/bourdin | +1 (905) 525 9140 ext. 27243
>> 
>> 
>>