[petsc-dev] obscure changes in TSGetStages_Theta

[Stefano Zampini]

You actually do not need a RestoreStages if you use a scratch

Vec stages[2];

in TS_theta, and pass it back with TSGetStages_Theta. I understand PETSc
philosophy is that every Get should have a Restore method, but is this
really necessary for TSGetStages?

Il giorno sab 23 gen 2021 alle ore 21:05 Zhang, Hong <hongzhang at anl.gov> ha
scritto:

> Done. Please check https://gitlab.com/petsc/petsc/-/merge_requests/3583
>
> Sorry for any disturbance it caused. It was for the convenience of the
> adjoint implementation. The stages returned by TSGetStages_Theta currently
> do not reflect the true stages associated with these methods. The endpoint
> variant actually has two stages. This will be changed in a separate
> forthcoming MR, where TSRestoreStages() will be added and TSGetStages will
> return an array of vectors for the endpoint variant.
>
> Hong
>
> On Jan 21, 2021, at 4:16 AM, Stefano Zampini <stefano.zampini at gmail.com>
> wrote:
>
> Hong,
>
> I do not understand why you changed the behavior of TSGetStages_Theta
> https://gitlab.com/petsc/petsc/-/merge_requests/3500/diffs#a582bbaec75f4ae14bbf97d1d0404073ca89ff09_1194_1209
> with this MR https://gitlab.com/petsc/petsc/-/merge_requests/3500
>
> Now, the non-endpoint variant does no longer use th->X as stage!
>
> Please revert this change
> Thanks
> --
> Stefano
>
>
>

-- 
Stefano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20210124/171101bc/attachment.html>