[petsc-dev] Gitlab notifications

[Jed Brown]

"Mills, Richard Tran via petsc-dev" <petsc-dev at mcs.anl.gov> writes:

> On 9/12/19 6:33 AM, Jed Brown via petsc-dev wrote:
> [...]
>> https://docs.gitlab.com/ee/user/project/code_owners.html
>>
>> We currently require approval from Integration (of which you are a
>> member) and a code owner (as specified in the file).
>>
>> We used to have optional approvals from any other developer, but Satish
>> just removed that due to this notification thing, which I guess means
>> that any other developer (non-integrator, non-owner) should just comment
>> their approval if they find time to review.
>
> Alright, this CODEOWNERS thing is new to me. I assume that everyone should go and edit this file and add themselves as "code owners" for the relevant portions of PETSc that they've done significant development on?

It's a statement that you want MRs to depend on your approval (or that
of a co-author) before being eligible to merge.