[petsc-dev] Gitlab notifications
Balay, Satish
balay at mcs.anl.gov
Thu Sep 12 08:39:02 CDT 2019
On Thu, 12 Sep 2019, Jed Brown via petsc-dev wrote:
> Matthew Knepley via petsc-dev <petsc-dev at mcs.anl.gov> writes:
>
> > On Thu, Sep 12, 2019 at 9:05 AM Balay, Satish via petsc-dev <
> > petsc-dev at mcs.anl.gov> wrote:
> >
> >> When a new MR is created, approval rules default to 'Integration' and
> >> 'Team'
> >>
> >> So everyone in the team probably receives emails on all MRs. Now that
> >> we have CODEOWNERS setup - perhaps the Team should be removed?
> >>
> >
> > Can you explain CODEOWNERS to me? I cannot find it on the GItlab site. I
> > want to see every MR.
>
> https://docs.gitlab.com/ee/user/project/code_owners.html
>
> We currently require approval from Integration (of which you are a
> member) and a code owner (as specified in the file).
>
> We used to have optional approvals from any other developer, but Satish
> just removed that due to this notification thing, which I guess means
> that any other developer (non-integrator, non-owner) should just comment
> their approval if they find time to review.
Ah - forgot the primary purpose of having 'Team' in the 'approve' list.
Is there a way to disable notifications for team - unless they participate?
Satish
More information about the petsc-dev
mailing list