[petsc-dev] I think the test system is broken in master

[Scott Kruger]

Thanks for the debugging, Satish -- I was very confused because I 
recently changed petscdiff and I assumed I rebugged it.

On 10/23/19 3:10 PM, Balay, Satish wrote:
> On Wed, 23 Oct 2019, Balay, Satish via petsc-dev wrote:
> 
>> On Wed, 23 Oct 2019, Matthew Knepley via petsc-dev wrote:
>>
>>> On Wed, Oct 23, 2019 at 4:20 PM Balay, Satish <balay at mcs.anl.gov> wrote:
>>>
>>> I am not saying the master branch tests are failing. I am saying that
>>> running the
>>> test system with REPLACE=1 is no longer working correctly.
>>
>> ok.
>>
>>>> On Wed, 23 Oct 2019, Matthew Knepley via petsc-dev wrote:
>>>>
>>>>> I just rebased my branch on master, and now with REPLACE=1 I am getting
>>>>>
>>>>> not ok diff-ksp_ksp_tutorials-ex70_fetidp # Error code: 1
>>>>> #       1,2d0
>>>>> #       <   DMSWARM_PIC: Using method CellDM->LocatePoints
>>>>> #       <   DMSWARM_PIC: Using method CellDM->GetNeigbors
>>>>> #       mv'ing ex70_fetidp.tmp -->
>>>>>
>>>> /var/folders/hk/tc1pd0g57l78rpt0lttc1sfh0000gn/T/petscdiff.XXXXXX.fjHMBkGr
>>
>> the destination of the 'mv' is wrong. So likely a bug in REPLACE wrt testset
>> [as non-testset example is working fine for me]
> 
> Actually the issue is with filter_output. And since 'mv' is done by petscdiff - it doesn't really work here..
> 
> "filter_output: grep -v atomic" gives: diff-ksp_ksp_tutorials-ex70_fetidp.sh
> grep -v atomic /home/balay/petsc/src/ksp/ksp/examples/tutorials/output/ex70_fetidp.out | /home/balay/petsc/lib/petsc/bin/petscdiff -m - ex70_fetidp.tmp > diff-runex70_fetidp.out 2> diff-runex70_fetidp.out
> 
> [without filter_output:]
> 
> /home/balay/petsc/lib/petsc/bin/petscdiff -m /home/balay/petsc/src/ksp/ksp/examples/tutorials/output/ex70_fetidp.out ex70_fetidp.tmp > diff-runex70_fetidp.out 2> diff-runex70_fetidp.out
> 
> 
> Perhaps "filter_output" codepath should be skippled when REPLACE=1 is specified [while invoking the diff]..

I don't understand how to fit this into the test harness.

Perhaps rather than trying to shoe horn that in, we could have a 
separate python script, `replace_test_output.py` that does it.
It is more manual, but more straightforward; e.g.,

config/replace_test_output.py 
--testdir=$PETSC_ARCH/tests/ksp/ksp/examples/tutorials


I always hated the filter_output feature...

Scott

> 
> Satish
> 
>>
>> [and not something that recently broke - so rebase with latest master
>> was not a factor - as v3.12 also has this breakage]
>>
>> Scott might have to take a look at this..
>>
>> Satish
>>
> 

-- 
Tech-X Corporation               kruger at txcorp.com
5621 Arapahoe Ave, Suite A       Phone: (720) 974-1841
Boulder, CO 80303                Fax:   (303) 448-7756