[petsc-dev] PETSc blame digest (next) 2019-06-20

[Jed Brown]

Hapla  Vaclav via petsc-dev <petsc-dev at mcs.anl.gov> writes:

>> On 20 Jun 2019, at 14:28, PETSc checkBuilds <petsc-checkbuilds at mcs.anl.gov> wrote:
>> 
>> 
>> 
>> Dear PETSc developer,
>> 
>> This email contains listings of contributions attributed to you by
>> `git blame` that caused compiler errors or warnings in PETSc automated
>> testing.  Follow the links to see the full log files. Please attempt to fix
>> the issues promptly or let us know at petsc-dev at mcs.anl.gov if you are unable
>> to resolve the issues.
>> 
>> Thanks,
>>  The PETSc development team
>> 
>> ----
>> 
>> warnings attributed to commit https://bitbucket.org/petsc/petsc/commits/eb91f32
>> MatLoad_Dense_HDF5 impl.
>> 
>>  src/mat/impls/dense/seq/densehdf5.c:62
>>    [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs//archive/2019/06/20/build_next_arch-linux-pkgs-cxx-mlib_el6.log]
>>      /home/sandbox/petsc/petsc.next-3/src/mat/impls/dense/seq/densehdf5.c:62: undefined reference to `PetscViewerHDF5Load'
>
> Does it mean I need to change visibility of PetscViewerHDF5Load in isimpl.h to PETSC_EXTERN?
> Are you OK with that?

Yes, and when doing that, it needs a Developer level man page.