[petsc-dev] [petsc-checkbuilds] PETSc blame digest (next) 2018-07-16

Satish Balay balay at mcs.anl.gov
Mon Jul 16 11:45:36 CDT 2018


http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/filtered-make_next_arch-linux-pkgs-64idx_thrash.log

>>>>
/sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1089:9: warning: passing argument 3 of ‘HYPRE_IJMatrixAddToValues’ from incompatible pointer type [enabled by default]
/sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1089:9: warning: passing argument 5 of ‘HYPRE_IJMatrixAddToValues’ from incompatible pointer type [enabled by default]
<<<<<

>>>>>>

-  PetscScalar        sscr[MATHYPRE_SCRATCH];
-  HYPRE_Int          cscr[2][MATHYPRE_SCRATCH];
-  HYPRE_Int          i,nzc;
+  PetscScalar        *sscr;
+  PetscInt           *cscr[2];
+  PetscInt           i,nzc;
+  void               *array;

PetscStackCallStandard(HYPRE_IJMatrixAddToValues,(hA->ij,1,&nzc,(HYPRE_Int*)(rows+i),cscr[0],sscr));                   
<<<<<<<<

So 'nzc' and 'cscr' types got changed from HYPRE_Int to PetscInt - causing this problem.


And this code is wierd..

>>>>>>>>
+static PetscErrorCode MatRestoreArray_HYPRE(Mat A, PetscInt size, void **array)
+{
+  Mat_HYPRE          *hA = (Mat_HYPRE*)A->data;
+
+  PetscFunctionBegin;
+  *array = NULL;
+  size = 0;
+  hA->available = PETSC_TRUE;
+  PetscFunctionReturn(0);
+}
+
<<<<<

Why does this routine need 'size' argument?

+  size = 0;

This is just a local variable - setting it to 0 does not do anything..



http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/filtered-make_next_arch-freebsd-cxx-pkgs-opt_wii.log
/usr/home/balay/petsc.next-2/src/mat/impls/hypre/mhypre.c:1075:20: warning: 'array' may be used uninitialized in this function [-Wmaybe-uninitialized]

http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/filtered-make_next_arch-linux-opt-misc_el6.log
/home/sandbox/petsc/petsc.next/src/mat/impls/hypre/mhypre.c:1103:53: warning: ‘array’ may be used uninitialized in this function [-Wmaybe-uninitialized]

This is a bit wierd. Different builds are giving warnings at different lines. And not all builds are warning about this.
http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/next.html

So - it must be the compiler/os combination.. I'll have to take a closer look..

Satish
   


On Mon, 16 Jul 2018, Matthew Knepley wrote:

> On Mon, Jul 16, 2018 at 11:38 AM Fande Kong <fdkong.jd at gmail.com> wrote:
> 
> > Hi Satish and Barry,
> >
> > Any way to reproduce these warnings? I just tried the same configure
> > script on my desktop, and I did NOT see any warning.
> >
> 
> You would need the same compiler/options. Is it not clear why they happen?
> 
>    Matt
> 
> 
> > Fande,
> >
> > On Mon, Jul 16, 2018 at 6:28 AM, PETSc checkBuilds <
> > petsc-checkbuilds at mcs.anl.gov> wrote:
> >
> >>
> >>
> >> Dear PETSc developer,
> >>
> >> This email contains listings of contributions attributed to you by
> >> `git blame` that caused compiler errors or warnings in PETSc automated
> >> testing.  Follow the links to see the full log files. Please attempt to
> >> fix
> >> the issues promptly or let us know at petsc-dev at mcs.anl.gov if you are
> >> unable
> >> to resolve the issues.
> >>
> >> Thanks,
> >>   The PETSc development team
> >>
> >> ----
> >>
> >> warnings attributed to commit
> >> https://bitbucket.org/petsc/petsc/commits/c69f721
> >> Added MatZeroEntries_HYPRE
> >>
> >>   src/mat/impls/hypre/mhypre.c:1103
> >>     [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/build_next_arch-linux-opt-misc_el6.log
> >> ]
> >>
> >> /home/sandbox/petsc/petsc.next/src/mat/impls/hypre/mhypre.c:1103:53:
> >> warning: 'array' may be used uninitialized in this function
> >> [-Wmaybe-uninitialized]
> >>     [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/build_next_arch-linux-pkgs-opt_crank.log
> >> ]
> >>       /sandbox/petsc/petsc.next/src/mat/impls/hypre/mhypre.c:1103:53:
> >> warning: 'array' may be used uninitialized in this function
> >> [-Wmaybe-uninitialized]
> >>
> >>   src/mat/impls/hypre/mhypre.c:1105
> >>     [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/build_next_arch-linux-pkgs-64idx_thrash.log
> >> ]
> >>       /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1105:9:
> >> warning: passing argument 3 of 'HYPRE_IJMatrixSetValues' from incompatible
> >> pointer type [enabled by default]
> >>     [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/build_next_arch-linux-pkgs-64idx_thrash.log
> >> ]
> >>       /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1105:9:
> >> warning: passing argument 5 of 'HYPRE_IJMatrixSetValues' from incompatible
> >> pointer type [enabled by default]
> >>
> >>   src/mat/impls/hypre/mhypre.c:1524
> >>     [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/build_next_arch-linux-pkgs-64idx_thrash.log
> >> ]
> >>       /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1524:5:
> >> warning: assignment from incompatible pointer type [enabled by default]
> >>
> >>   src/mat/impls/hypre/mhypre.c:1525
> >>     [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/build_next_arch-linux-pkgs-64idx_thrash.log
> >> ]
> >>       /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1525:5:
> >> warning: assignment from incompatible pointer type [enabled by default]
> >>
> >>   src/mat/impls/hypre/mhypre.c:1582
> >>     [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/build_next_arch-linux-pkgs-64idx_thrash.log
> >> ]
> >>       /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1582:3:
> >> warning: passing argument 4 of 'HYPRE_ParCSRMatrixGetRow' from incompatible
> >> pointer type [enabled by default]
> >>     [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/build_next_arch-linux-pkgs-64idx_thrash.log
> >> ]
> >>       /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1582:3:
> >> warning: passing argument 3 of 'HYPRE_ParCSRMatrixGetRow' from incompatible
> >> pointer type [enabled by default]
> >>
> >>   src/mat/impls/hypre/mhypre.c:1595
> >>     [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/build_next_arch-linux-pkgs-64idx_thrash.log
> >> ]
> >>       /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1595:3:
> >> warning: passing argument 4 of 'HYPRE_ParCSRMatrixRestoreRow' from
> >> incompatible pointer type [enabled by default]
> >>     [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/build_next_arch-linux-pkgs-64idx_thrash.log
> >> ]
> >>       /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1595:3:
> >> warning: passing argument 3 of 'HYPRE_ParCSRMatrixRestoreRow' from
> >> incompatible pointer type [enabled by default]
> >>
> >>   src/mat/impls/hypre/mhypre.c:1613
> >>     [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07/16/build_next_arch-linux-pkgs-64idx_thrash.log
> >> ]
> >>       /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1613:5:
> >> warning: passing argument 3 of 'HYPRE_IJMatrixGetValues' from incompatible
> >> pointer type [enabled by default]
> >>
> >> ----
> >> To opt-out from receiving these messages - send a request to
> >> petsc-dev at mcs.anl.gov.
> >>
> >
> >
> 
> 


More information about the petsc-dev mailing list