[petsc-dev] Possible bug in PCFIELDSPLIT

[Smith, Barry F.]

  Fixed in master


> On Jan 10, 2018, at 10:41 AM, Lisandro Dalcin <dalcinl at gmail.com> wrote:
> 
> On 10 January 2018 at 18:43, Smith, Barry F. <bsmith at mcs.anl.gov> wrote:
>> 
>>   Are you pointing out there is a missing atype == in the inner check and it should be
>> 
>>> atype ==
>>> MAT_SCHUR_COMPLEMENT_AINV_DIAG ? "" :
>>> (atype == MAT_SCHUR_COMPLEMENT_AINV_BLOCK_DIAG ? "block " : "lumped
>> 
>> ?
>> 
> 
> I don't know :-) I got the warning from a build using GCC 7.2 while
> working on something else, and the code snippet pointed by the
> compiler looks really suspicious to me, so I posted it here before I
> forget about it. I guess your diagnostic is correct, the code is just
> missing the inner "atype ==" part you wrote.
> 
> 
> 
> 
> -- 
> Lisandro Dalcin
> ============
> Research Scientist
> Computer, Electrical and Mathematical Sciences & Engineering (CEMSE)
> Extreme Computing Research Center (ECRC)
> King Abdullah University of Science and Technology (KAUST)
> http://ecrc.kaust.edu.sa/
> 
> 4700 King Abdullah University of Science and Technology
> al-Khawarizmi Bldg (Bldg 1), Office # 0109
> Thuwal 23955-6900, Kingdom of Saudi Arabia
> http://www.kaust.edu.sa
> 
> Office Phone: +966 12 808-0459