[petsc-dev] FAS indentation

[Dener, Alp]

Sounds good. I already found one case of mishandled tabs just looking at the SNES default monitor, and I’ll make sure the rest don’t have the same bug.

—
Alp Dener


On April 3, 2018 at 6:24:42 PM, Matthew Knepley (knepley at gmail.com<mailto:knepley at gmail.com>) wrote:

On Tue, Apr 3, 2018 at 7:16 PM, Dener, Alp <adener at anl.gov<mailto:adener at anl.gov>> wrote:
Sure thing!

Matt, just to give you a bit of detail, the Monitor() calls to ASCII viewers were changed to respect the tab levels for the parent objects instead of manually pushing and popping tabs on the printouts. The code also tries to preserve the existing tab levels of the viewer though — that is, we first save the existing tab level, then indent monitor printouts from the root (0 tab) using the object’s tab level, and then set the viewer back to whatever tab level it was at before the monitor is called. So in theory, it shouldn’t be changing the behavior of the viewer outside of the monitor. It is entirely possible I introduced a bug somewhere and that’s what I’m going to look for right now, but in the meantime please let me know if there’s a use-case or a test I can use for debugging as well.

The easiest thing to do is run all the SNES ex12 tests in next and look at the indentation errors. I am now pushing fixes for all other errors, so
by the time you run there should be nothing else.

  Thanks,

     Matt

Thanks,
—
Alp Dener


On April 3, 2018 at 6:11:12 PM, Smith, Barry F. (bsmith at mcs.anl.gov<mailto:bsmith at mcs.anl.gov>) wrote:

Alp,

Can you please take a look at this?

Thanks

Barry


> On Apr 3, 2018, at 4:46 PM, Matthew Knepley <knepley at gmail.com<mailto:knepley at gmail.com>> wrote:
>
> The recent indentation fix (I think) has broken the FAS solver indentation.
>
> Matt
>
> --
> What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.
> -- Norbert Wiener
>
> https://www.cse.buffalo.edu/~knepley/




--
What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.
-- Norbert Wiener

https://www.cse.buffalo.edu/~knepley/<http://www.caam.rice.edu/~mk51/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20180403/8d69852b/attachment-0001.html>