[petsc-dev] Fwd: PETSc blame digest (next) 2016-03-15
Satish Balay
balay at mcs.anl.gov
Tue Mar 15 10:59:46 CDT 2016
How about:
http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/03/15/filtered-make_next_arch-freebsd-cxx-cmplx-pkgs-dbg_wii.log
/usr/home/balay/petsc.clone-3/src/vec/vec/utils/ftn-auto/vscatf.c: In function 'void vecscatterinitializeforgpu_(VecScatter, Vec, ScatterMode*, int*)':
/usr/home/balay/petsc.clone-3/src/vec/vec/utils/ftn-auto/vscatf.c:100:33: error: 'VecScatterInitializeForGPU' was not declared in this scope
(Vec)PetscToPointer((x) ),*mode);
For one - there is some inconsistancy in the definition of this function wrt interface vs impl.
I'm not sure what our policy here is . Always have this function
available in public API - or selectively have it enabled? Either way -
it should be consistant across sources (include, c-interface, fortran-interface).
How about: [always have the function available]
diff --git a/include/petscvec.h b/include/petscvec.h
index 2391c39..4d07175 100644
--- a/include/petscvec.h
+++ b/include/petscvec.h
@@ -533,14 +533,14 @@ PETSC_EXTERN PetscErrorCode VecsCreateSeq(MPI_Comm,PetscInt,PetscInt,Vecs*);
PETSC_EXTERN PetscErrorCode VecsCreateSeqWithArray(MPI_Comm,PetscInt,PetscInt,PetscScalar*,Vecs*);
PETSC_EXTERN PetscErrorCode VecsDuplicate(Vecs,Vecs*);
+PETSC_EXTERN PetscErrorCode VecScatterInitializeForGPU(VecScatter,Vec,ScatterMode);
+PETSC_EXTERN PetscErrorCode VecScatterFinalizeForGPU(VecScatter);
#if defined(PETSC_HAVE_CUSP)
typedef struct _p_PetscCUSPIndices* PetscCUSPIndices;
typedef struct _p_VecScatterCUSPIndices_StoS* VecScatterCUSPIndices_StoS;
typedef struct _p_VecScatterCUSPIndices_PtoP* VecScatterCUSPIndices_PtoP;
PETSC_EXTERN PetscErrorCode VecCUSPCopyToGPUSome_Public(Vec,PetscCUSPIndices);
PETSC_EXTERN PetscErrorCode VecCUSPCopyFromGPUSome_Public(Vec,PetscCUSPIndices);
-PETSC_EXTERN PetscErrorCode VecScatterInitializeForGPU(VecScatter,Vec,ScatterMode);
-PETSC_EXTERN PetscErrorCode VecScatterFinalizeForGPU(VecScatter);
PETSC_EXTERN PetscErrorCode VecCreateSeqCUSP(MPI_Comm,PetscInt,Vec*);
PETSC_EXTERN PetscErrorCode VecCreateMPICUSP(MPI_Comm,PetscInt,PetscInt,Vec*);
#elif defined(PETSC_HAVE_VIENNACL)
@@ -557,8 +557,6 @@ typedef struct _p_VecScatterCUDAIndices_StoS* VecScatterCUDAIndices_StoS;
typedef struct _p_VecScatterCUDAIndices_PtoP* VecScatterCUDAIndices_PtoP;
PETSC_EXTERN PetscErrorCode VecCUDACopyToGPUSome_Public(Vec,PetscCUDAIndices);
PETSC_EXTERN PetscErrorCode VecCUDACopyFromGPUSome_Public(Vec,PetscCUDAIndices);
-PETSC_EXTERN PetscErrorCode VecScatterInitializeForGPU(VecScatter,Vec,ScatterMode);
-PETSC_EXTERN PetscErrorCode VecScatterFinalizeForGPU(VecScatter);
PETSC_EXTERN PetscErrorCode VecCreateSeqCUDA(MPI_Comm,PetscInt,Vec*);
PETSC_EXTERN PetscErrorCode VecCreateMPICUDA(MPI_Comm,PetscInt,PetscInt,Vec*);
#endif
To have it selectively available - the function should be moved to a
different source dir - with a makefile that can enable/disable compile
with '#requires PETSC_HAVE_CUSP' - so that both C and fortran
interfaces can be enabled or disabled together..
Satish
On Tue, 15 Mar 2016, Matthew Knepley wrote:
> On Tue, Mar 15, 2016 at 10:35 AM, Karl Rupp <rupp at iue.tuwien.ac.at> wrote:
>
> > Hey,
> >
> > Who merged this?
> >>
> >>
> >> https://bitbucket.org/petsc/petsc/commits/266b9d3e75ff0e2d2cb13a56c78c1e875c6f6ad0?at=next
> >>
> >> You need to add the vecimpl.h include in the Plex files that were changed.
> >>
> >
> > Fixed here in the pull request branch:
> >
> > https://bitbucket.org/petsc/petsc/commits/e5c6e7917ad449ee1fe38b95126ddb02607b9a15
> >
> > and merged to next.
> >
>
> Cool.
>
> Thanks,
>
> Matt
>
>
> > Best regards,
> > Karli
> >
> >
> >
> > ---------- Forwarded message ----------
> >> From: *PETSc checkBuilds* <petsc-checkbuilds at mcs.anl.gov
> >> <mailto:petsc-checkbuilds at mcs.anl.gov>>
> >> Date: Tue, Mar 15, 2016 at 9:00 AM
> >> Subject: PETSc blame digest (next) 2016-03-15
> >> To: Matthew Knepley <knepley at gmail.com <mailto:knepley at gmail.com>>,
> >> PETSc checkBuilds <petsc-checkbuilds at mcs.anl.gov
> >> <mailto:petsc-checkbuilds at mcs.anl.gov>>
> >>
> >>
> >>
> >>
> >> Dear PETSc developer,
> >>
> >> This email contains listings of contributions attributed to you by
> >> `git blame` that caused compiler errors or warnings in PETSc automated
> >> testing. Follow the links to see the full log files. Please attempt to
> >> fix
> >> the issues promptly or let us know at petsc-dev at mcs.anl.gov
> >> <mailto:petsc-dev at mcs.anl.gov> if you are unable
> >>
> >> to resolve the issues.
> >>
> >> Thanks,
> >> The PETSc development team
> >>
> >> ----
> >>
> >> warnings attributed to commit
> >> https://bitbucket.org/petsc/petsc/commits/55f2e96
> >> DMPlex: Added DMPlexInsertBoundaryValues()
> >>
> >> src/dm/impls/plex/plex.c:92
> >>
> >> [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/03/15/build_next_arch-linux-uni_crush.log
> >> ]
> >> /sandbox/petsc/petsc.clone-2/src/dm/impls/plex/plex.c:92:5:
> >> warning: implicit declaration of function 'VecView_Seq'
> >> [-Wimplicit-function-declaration]
> >>
> >> [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/03/15/build_next_arch-linux-gcc-pgf90_grind.log
> >> ]
> >> /sandbox/petsc/petsc.clone-2/src/dm/impls/plex/plex.c:92:5:
> >> warning: implicit declaration of function 'VecView_Seq'
> >> [-Wimplicit-function-declaration]
> >>
> >> [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/03/15/build_next_arch-opensolaris-misc_n-gage.log
> >> ]
> >> "/export/home/petsc/petsc.clone-2/src/dm/impls/plex/plex.c", line
> >> 92: warning: implicit function declaration: VecView_Seq
> >>
> >> [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/03/15/build_next_arch-linux-gcc-ifc-cmplx_crank.log
> >> ]
> >> /sandbox/petsc/petsc.clone-2/src/dm/impls/plex/plex.c:92:5:
> >> warning: implicit declaration of function 'VecView_Seq'
> >> [-Wimplicit-function-declaration]
> >>
> >> [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/03/15/build_next_arch-cuda-single_frog.log
> >> ]
> >> /home/balay/petsc.clone-2/src/dm/impls/plex/plex.c:92:5: warning:
> >> implicit declaration of function 'VecView_Seq'
> >> [-Wimplicit-function-declaration]
> >>
> >> [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/03/15/build_next_arch-linux-pkgs-dbg-ftn-interfaces_crank.log
> >> ]
> >> /sandbox/petsc/petsc.clone-3/src/dm/impls/plex/plex.c:92:24:
> >> warning: implicit declaration of function 'VecView_Seq' is invalid in
> >> C99 [-Wimplicit-function-declaration]
> >>
> >> [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/03/15/build_next_arch-c-exodus-dbg-builder_frog.log
> >> ]
> >> /home/balay/petsc.clone-3/src/dm/impls/plex/plex.c:92:5: warning:
> >> implicit declaration of function 'VecView_Seq'
> >> [-Wimplicit-function-declaration]
> >>
> >> [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/03/15/build_next_arch-opensolaris-cmplx-pkgs-dbg_n-gage.log
> >> ]
> >> "/export/home/petsc/petsc.clone-3/src/dm/impls/plex/plex.c", line
> >> 92: warning: implicit function declaration: VecView_Seq
> >>
> >> [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/03/15/build_next_arch-linux-pkgs-64idx_thrash.log
> >> ]
> >> /sandbox/petsc/petsc.clone-3/src/dm/impls/plex/plex.c:92:5:
> >> warning: implicit declaration of function 'VecView_Seq'
> >> [-Wimplicit-function-declaration]
> >>
> >> [
> >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/03/15/build_next_arch-linux-dbg-quad_churn.log
> >> ]
> >> /sandbox/petsc/petsc.clone-3/src/dm/impls/plex/plex.c:92:5:
> >> warning: implicit declaration of function 'VecView_Seq'
> >> [-Wimplicit-function-declaration]
> >>
> >> ----
> >> To opt-out from receiving these messages - send a request to
> >> petsc-dev at mcs.anl.gov <mailto:petsc-dev at mcs.anl.gov>.
> >>
> >>
> >>
> >> --
> >> What most experimenters take for granted before they begin their
> >> experiments is infinitely more interesting than any results to which
> >> their experiments lead.
> >> -- Norbert Wiener
> >>
> >
> >
>
>
>
More information about the petsc-dev
mailing list