[petsc-dev] Matt, please don't put buggy code into PETSc

[Jed Brown]

Matthew Knepley <knepley at gmail.com> writes:
> Yes, I am aware, and as I pointed out, I was checking the complex build,

You didn't mention "complex" in this thread, just something about C
typedefs which isn't true because you get warnings like this in C.

warning: incompatible pointer types passing 'PetscScalar *' (aka '_Complex double *') to parameter of type 'PetscReal *' (aka 'double *') [-Wincompatible-pointer-types]
    ierr = VecNorm(Z,NORM_2,&dp);CHKERRQ(ierr);                /*    dp <- z'*z = e'*A'*B'*B*A'*e'     */
                            ^~~

> but not the examples because it is so noisy.

Building a single executable for all the tests would make it trivial to
check that they all compile cleanly.  Making the runs completely clean
brings back the difficulty of comparing output.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20140119/a17bd623/attachment.sig>