[petsc-dev] Matt, please don't put buggy code into PETSc

[Matthew Knepley]

On Sun, Jan 19, 2014 at 4:57 PM, Barry Smith <bsmith at mcs.anl.gov> wrote:

>
> src/mat/examples/tests/ex18.c
>
> passes a PetscScalar to VecNorm.
>

I missed it when I went over the example, and C does not check typedefs,
only
the underlying type.


> When the hell are we going to have some simple checks on bad code being
> pushed in petsc?


I checked the compiles every day, but not the examples since there is so
much noise. So

  a) we could lump the example compiles in with the build. I like this one

  b) we can cleanup all the example noise. I have started this, but it is a
big job.

   Matt


>
>    Barry
>
>


-- 
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which their
experiments lead.
-- Norbert Wiener
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20140119/d0c054ee/attachment.html>