[petsc-dev] sor smoothers

Jed Brown jedbrown at mcs.anl.gov
Sun Sep 8 16:09:42 CDT 2013


Barry Smith <bsmith at mcs.anl.gov> writes:

>    I actually like having the typedefs in these situations even if
>    there is a portable alternative. It makes it clear what the purpose
>    of the variable is, if everything is just labeled double, int or
>    long int you don't know immediately what it represents. For example
>    PetscErrorCode and PetscLogDouble (maybe a bad name) or
>    PetscClassId.  We started with int for PetscErrorCode and I found
>    changing it really clarified the source code.
>
>   For these we could use PetscObjectState, PetscObjectId, or something
>   else.

I have no problem with typedefs based on _intent_, but it may be that
Petsc64bitUInt is unnecessary.  If stdint.h is now ubiquitious enough,
then we just use

  typedef uint64_t PetscObjectId;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20130908/7e8ca6cc/attachment.sig>


More information about the petsc-dev mailing list