[petsc-dev] Function pointer conversion: undefined behavior

Karl Rupp rupp at mcs.anl.gov
Fri Jan 25 11:06:53 CST 2013


Hi Jed,

>     In the nightly tests are only very few warnings of that type left.
>     Only 11 files affected with about ~7 warnings each on average:
>        vec/pf/impls/constant/const.c
>        mat/matfd/ftn-custom/__zfdmatrixf.c
>        mat/impls/mffd/ftn-custom/__zmffdf.c
>        ksp/pc/impls/tfs/comm.c
>        ksp/pc/impls/tfs/xxt.c
>        ksp/pc/impls/tfs/xyt.c
>        ksp/ksp/interface/ftn-custom/__zitfuncf.c
>        snes/interface/ftn-custom/__zsnesf.c
>        snes/utils/dmsnes.c
>        ts/interface/ftn-custom/ztsf.c
>        ts/utils/dmts.c:65
>     Please let me know if I can be of any help.
>
>
> It's not fun work, but if you want to have the honor of deleting some of
> the ugliest code in PETSc, just apply the pattern here to those
> ftn-custom cases.
>
> https://bitbucket.org/petsc/petsc-dev/commits/f2a68b8a037e
>
> I'll get around to it if you don't.

Alright, I'll give it a try. There's snow outside, so I have a morale 
bonus today which I can use :-)

Best regards,
Karli




More information about the petsc-dev mailing list