[petsc-dev] Style Guide: How to format single-line if/for/while-blocks?

[Matthew Knepley]

On Mon, Jan 21, 2013 at 7:23 PM, Karl Rupp <rupp at mcs.anl.gov> wrote:

> Hi,
>
>
>
>>               Things like
>>
>>               if (y < 12) {ierr = Something(); CHKERRQ(ierr);}
>>
>>         don't match the standard but …. am I being too picky? I believe
>>         the PETSc make uncrustify rule would move that to separate lines.
>>
>>
>>     I expect that it's a lot easier to define a rule where '{' opens a
>>     new block on the next line rather than having a 'sometimes it's a
>>     single line'-type of exception.
>>
>>
>> Yes, though
>>
>> if (y < 12) {
>>    ierr = Something();CHKERRQ(ierr);
>> }
>>
>> takes three times as many lines. I don't care much either way, but it's
>> nice to not waste vertical space.
>>
>
> But, unfortunately, it is also a good example of why uncrustify-like tools
> have a hard time with PETSc:
>
>
>  if (y < 12) {
>     ierr = Something();
>     call_other_function(ierr);
>  }
>
> is semantically very much the same to a parser, yet it should lead to
> different formatting.
>

Its my belief that tools are there to help us do the things we want to do,
not to determine what we do.

   Matt


> Best regards,
> Karli
>

-- 
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which their
experiments lead.
-- Norbert Wiener
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20130121/e76e9d37/attachment.html>