[petsc-dev] [Bitbucket] Commit 67125ba: metis/parmetis: update to metis-5.1.0/parmetis-4.0.3 (petsc/petsc)

[Jed Brown]

I would remove it, but shouldn't *we* be picking which options are used to compile?

Satish Balay <balay at mcs.anl.gov> writes:

> BTW: meits has this change between 5.0.2 and 5.1.0 - which I can revert
> [as its the primary cause of this breakage]
>
> $ git diff v5.0.2..v5.1.0 GKlib/GKlibSystem.cmake
> diff --git a/GKlib/GKlibSystem.cmake b/GKlib/GKlibSystem.cmake
> index 7ea5bab..3fcc291 100644
> --- a/GKlib/GKlibSystem.cmake
> +++ b/GKlib/GKlibSystem.cmake
> @@ -33,7 +33,7 @@ if(CMAKE_COMPILER_IS_GNUCC)
>        set(GKlib_COPTIONS "${GKlib_COPTIONS} -fPIC")
>    endif(NOT MINGW)
>  # GCC warnings.
> -  set(GKlib_COPTIONS "${GKlib_COPTIONS} -Wall -pedantic -Wno-unused-variable -Wno-unknown-pragmas")
> +  set(GKlib_COPTIONS "${GKlib_COPTIONS} -Wall -pedantic -Wno-unused-but-set-variable -Wno-unused-variable -Wno-unknown-pragmas")
>  elseif(${CMAKE_C_COMPILER_ID} MATCHES "Sun")
>  # Sun insists on -xc99.
>    set(GKlib_COPTIONS "${GKlib_COPTIONS} -xc99")
>
>
> On Tue, 27 Aug 2013, Satish Balay wrote:
>
>> On Tue, 27 Aug 2013, Jed Brown wrote:
>> 
>> > --- you can reply above this line ---
>> > 
>> > New comment on commit:
>> > 
>> > https://bitbucket.org/petsc/petsc/commits/67125baed9b71bdad2cf52a801605839abb603c5#comment-394762
>> > 
>> > Jed Brown said:
>> > 
>> >     Stop in /usr/home/balay/petsc.clone/externalpackages/metis-5.1.0-p1/arch-freebsd-pkgs-opt.cc1: error: unrecognized command line option "-Wno-unused-but-set-variable"
>> > 
>> > http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/build_next_arch-freebsd-pkgs-opt_wii.log
>> > http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/build_next_arch-osx-10.6-cxx-cmplx-pkgs-dbg_petsc-mini.mcs.anl.gov.log
>> 
>> >>>>>>>>>>
>> cd /usr/home/balay/petsc.clone/externalpackages/metis-5.1.0-p1/arch-freebsd-pkgs-opt/libmetis && /usr/home/balay/petsc.clone/arch-freebsd-pkgs-opt/bin/mpicc  -Dmetis_EXPORTS -fPIC -Wall -Wwrite-strings -Wno-strict-aliasing -Wno-unknown-pragmas -O -DLINUX -D_FILE_OFFSET_BITS=64 -std=c99 -fno-strict-aliasing -fPIC -Wall -pedantic -Wno-unused-but-set-variable -Wno-unused-variable -Wno-unknown-pragmas -DNDEBUG -DNDEBUG2 -DHAVE_GETLINE -O3 -fPIC -I/usr/home/balay/petsc.clone/externalpackages/metis-5.1.0-p1/GKlib -I/usr/home/balay/petsc.clone/externalpackages/metis-5.1.0-p1/include -I/usr/home/balay/petsc.clone/externalpackages/metis-5.1.0-p1/libmetis/. -I/usr/home/balay/petsc.clone/externalpackages/metis-5.1.0-p1/arch-freebsd-pkgs-opt/include -o CMakeFiles/metis.dir/__/GKlib/b64.c.o   -c /usr/home/balay/petsc.clone/externalpackages/metis-5.1.0-p1/GKlib/b64.c
>> *** [libmetis/CMakeFiles/metis.dir/__/GKlib/b64.c.o] Error code 1
>> Stop in /usr/home/balay/petsc.clone/externalpackages/metis-5.1.0-p1/arch-freebsd-pkgs-opt.
>> *** [libmetis/CMakeFiles/metis.dir/all] Error code 1
>> Stop in /usr/home/balay/petsc.clone/externalpackages/metis-5.1.0-p1/arch-freebsd-pkgs-opt.
>> *** [all] Error code 1
>> Stop in /usr/home/balay/petsc.clone/externalpackages/metis-5.1.0-p1/arch-freebsd-pkgs-opt.cc1: error: unrecognized command line option "-Wno-unused-but-set-variable"
>> <<<<<<<<<<<<
>> 
>> GKlib/GKlibSystem.cmake has:
>> 
>> >>>>>>>>>>>>
>> # Add compiler flags.
>> if(MSVC)
>>   set(GKlib_COPTS "/Ox")
>>   set(GKlib_COPTIONS "-DWIN32 -DMSC -D_CRT_SECURE_NO_DEPRECATE -DUSE_GKREGEX")
>> elseif(MINGW)
>>   set(GKlib_COPTS "-DUSE_GKREGEX")
>> else()
>>   set(GKlib_COPTS "-O3")
>>   set(GKlib_COPTIONS "-DLINUX -D_FILE_OFFSET_BITS=64")
>> endif(MSVC)
>> if(CYGWIN)
>>   set(GKlib_COPTIONS "${GKlib_COPTIONS} -DCYGWIN")
>> endif(CYGWIN)
>> if(CMAKE_COMPILER_IS_GNUCC)
>> # GCC opts.
>>   set(GKlib_COPTIONS "${GKlib_COPTIONS} -std=c99 -fno-strict-aliasing")
>>   if(NOT MINGW)
>>       set(GKlib_COPTIONS "${GKlib_COPTIONS} -fPIC")
>>   endif(NOT MINGW)
>> # GCC warnings.
>>   set(GKlib_COPTIONS "${GKlib_COPTIONS} -Wall -pedantic -Wno-unused-but-set-variable -Wno-unused-variable -Wno-unknown-pragmas")
>> endif(CMAKE_COMPILER_IS_GNUCC)
>> <<<<<<<<<
>> 
>> Hm - don't unserstand cmake - but looks like metis/parmetis is hardcoding
>> flags [based on compiler - instead of using user provided flags at configure time?
>> 
>> >>>>>>>>
>> Executing: cd /usr/home/balay/petsc.clone/externalpackages/metis-5.1.0-p1/arch-freebsd-pkgs-opt && /usr/home/balay/petsc.clone/arch-freebsd-pkgs-opt/bin/cmake .. -DCMAKE_INSTALL_PREFIX=/usr/home/balay/petsc.clone/arch-freebsd-pkgs-opt -DCMAKE_VERBOSE_MAKEFILE=1 -DGKLIB_PATH=../GKlib -DCMAKE_C_COMPILER="/usr/home/balay/petsc.clone/arch-freebsd-pkgs-opt/bin/mpicc" -DCMAKE_AR=/usr/bin/ar -DCMAKE_RANLIB=/usr/bin/ranlib -DCMAKE_C_FLAGS:STRING=" -fPIC -Wall -Wwrite-strings -Wno-strict-aliasing -Wno-unknown-pragmas -O " -DSHARED=1 -DMETIS_USE_DOUBLEPRECISION=1
>> <<<<<<<<<<
>> 
>> Is there a way to override this stuff with 'cmake options'? [and not modify this file?]
>> 
>> 
>> > 
>> > (We should probably be making these links stable so that they still make sense tomorrow.)
>> 
>> The stable urls are nightlylogs/archive/date. I'll have the top level
>> index.html automatically redirect to the correct location - so that
>> the urls [after redirect] are stable.
>> 
>> Satish
>> 
>> > 
>> > --
>> > 
>> > Unwatch this commit to stop receiving email updates:
>> > https://bitbucket.org/petsc/petsc/commits/67125baed9b71bdad2cf52a801605839abb603c5/unwatch/balay/225fa74abc610eecc67a3d0e44502277bf0695f1/
>> > 
>> 
>> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20130827/6c2ecfdb/attachment.sig>