[petsc-dev] usage of string.h

Satish Balay balay at mcs.anl.gov
Thu Apr 25 17:44:07 CDT 2013


I see the usage of string.h is removed from petsc sources.

https://bitbucket.org/petsc/petsc/commits/b083e2b6e0be6f731fe9e787c55cf4647c46b29
https://bitbucket.org/petsc/petsc/commits/573b0fb4b27458e353e9b121e629dc5c63cf6459

The remove of strings.h from str.c is added back in
https://bitbucket.org/petsc/petsc/commits/3964eb8815a373d98cd54ebd45324cfa27b228df

Now I see a breakage in windows64 build with strstr() [usded in str.c]
- fixable by adding back string.h

Is this the correct fix? Whats the intention of remove these includes?

thanks,
Satish



More information about the petsc-dev mailing list