[petsc-dev] Patches like this make me want to cry

Paul Mullowney paulm at txcorp.com
Thu Jun 28 17:41:42 CDT 2012

I moved all CUSPARSE functions into seqcusparse/aijcusparse.cu (and a 
similar mpi version). I was asked to do this some months ago. I did my 
best. I think it is significantly improved from before.

I was also asked by multiple people to attempt to get Complex GPU 
capabilities working. I succeeded by making changes to petscmath.h. As 
Jed pointed out, some of the changes may have not been C99 compliant.

There is one commented out function in aijcusparse.cu. That can easily 
be fixed.

Many of the other changes (especially to .cu) files were made to protect 
against builds breaking because many of the CUSP preconditioners do not 
support complex arithmetic.

I have asked for input from multiple people on several occasions and not 
gotten responses.

What am I to do if I ask for input/feedback and don't get it?????


> There are essentially no comments on this massive push. I was just 
> reading it, getting mad. Jed mailed first.
> Pushes need enough comments that I can see exactly what functionality 
> is being added and how it works.
> You will not be the maintainer of this functionality, we will. If we 
> can't do it, it will be thrown out, and all your
> time will be wasted.
>    Matt
>             This is non-portable:
>             http://petsc.cs.iit.edu/petsc/petsc-dev/rev/66ca8db0d5f8
>             Can we please institute some sort of policy on patch
>             quality/reviewability? This one patch is going to take a
>             significant amount of fix-up (not made easier by the
>             several merges since) and/or generate several build
>             failures and user inconvenience (petsc-maints). No doubt
>             the functionality is important, but we just don't have
>             time to fix these things line-by-line after they are pushed.
> -- 
> What most experimenters take for granted before they begin their 
> experiments is infinitely more interesting than any results to which 
> their experiments lead.
> -- Norbert Wiener

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120628/f63ac2a0/attachment.html>

More information about the petsc-dev mailing list