<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I moved all CUSPARSE functions into seqcusparse/aijcusparse.cu (and
a similar mpi version). I was asked to do this some months ago. I
did my best. I think it is significantly improved from before.<br>
<br>
I was also asked by multiple people to attempt to get Complex GPU
capabilities working. I succeeded by making changes to petscmath.h.
As Jed pointed out, some of the changes may have not been C99
compliant. <br>
<br>
There is one commented out function in aijcusparse.cu. That can
easily be fixed. <br>
<br>
Many of the other changes (especially to .cu) files were made to
protect against builds breaking because many of the CUSP
preconditioners do not support complex arithmetic.<br>
<br>
I have asked for input from multiple people on several occasions and
not gotten responses. <br>
<br>
What am I to do if I ask for input/feedback and don't get it?????<br>
<br>
-Paul<br>
<br>
<br>
<blockquote
cite="mid:CAMYG4GnyPMszL2c_szTDRbWwj7ku_VkCg3rW5Sg=TAU3Mj9tOw@mail.gmail.com"
type="cite">
<div class="gmail_quote">
<div><br>
</div>
<div>There are essentially no comments on this massive push. I
was just reading it, getting mad. Jed mailed first.</div>
<div>Pushes need enough comments that I can see exactly what
functionality is being added and how it works.</div>
<div>You will not be the maintainer of this functionality, we
will. If we can't do it, it will be thrown out, and all your</div>
<div>time will be wasted.</div>
<div><br>
</div>
<div> Matt</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_quote">
<div class="im">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div><br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
This is non-portable:<br>
<br>
<a moz-do-not-send="true"
href="http://petsc.cs.iit.edu/petsc/petsc-dev/rev/66ca8db0d5f8"
target="_blank">http://petsc.cs.iit.edu/petsc/petsc-dev/rev/66ca8db0d5f8</a><br>
<br>
<br>
Can we please institute some sort of policy on
patch quality/reviewability? This one patch is
going to take a significant amount of fix-up (not
made easier by the several merges since) and/or
generate several build failures and user
inconvenience (petsc-maints). No doubt the
functionality is important, but we just don't have
time to fix these things line-by-line after they
are pushed.<br>
</blockquote>
<br>
</div>
</div>
</blockquote>
</div>
</div>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to
which their experiments lead.<br>
-- Norbert Wiener<br>
</blockquote>
<br>
</body>
</html>