[petsc-dev] Line search routine duplication

Barry Smith bsmith at mcs.anl.gov
Fri Sep 9 15:45:36 CDT 2011


On Sep 9, 2011, at 3:37 PM, Peter Brune wrote:

> The line search routines exposed through petscsnes.h (SNESXXXLineSearch and ilk) live in src/snes/ls are dependent on the private context of the ls newton method.  This seems to have caused a fairly large degree of code duplication of useful pieces in ls, picard, and qn.
> 
> Would moving all of these somewhere else and removing their dependency on ls specific solver context be a reasonable course of action?

   Yes, but not yet.  Keep on doing separate ones and once we have a complete collection we'll look at them all and determine the commonalities. I don't want to do it yet because I don't think we have all the cases yet.

   Barry

> 
> - Peter




More information about the petsc-dev mailing list