[petsc-dev] incomplete fix for MatSetValuesStencil() someone recently made

[Lisandro Dalcin]

On 24 May 2011 00:51, Barry Smith <bsmith at mcs.anl.gov> wrote:
>
> libfast in: /Users/barrysmith/Src/petsc-dev/src/mat/interface
> matrix.c: In function ‘PetscErrorCode MatSetValuesStencil(_p_Mat*, PetscInt, const MatStencil*, PetscInt, const MatStencil*, const PetscScalar*, InsertMode)’:
> matrix.c:1317: warning: comparison between signed and unsigned integer expressions
> matrix.c: In function ‘PetscErrorCode MatSetValuesBlockedStencil(_p_Mat*, PetscInt, const MatStencil*, PetscInt, const MatStencil*, const PetscScalar*, InsertMode)’:
> matrix.c:1430: warning: comparison between signed and unsigned integer expressions
> matrix.c: In function ‘PetscErrorCode MatSetValuesBlocked(_p_Mat*, PetscInt, const PetscInt*, PetscInt, const PetscInt*, const PetscScalar*, InsertMode)’:
> matrix.c:1614: warning: comparison between signed and unsigned integer expressions
> matrix.c: In function ‘PetscErrorCode MatSetValuesLocal(_p_Mat*, PetscInt, const PetscInt*, PetscInt, const PetscInt*, const PetscScalar*, InsertMode)’:
> matrix.c:1905: warning: comparison between signed and unsigned integer expressions
> matrix.c: In function ‘PetscErrorCode MatSetValuesBlockedLocal(_p_Mat*, PetscInt, const PetscInt*, PetscInt, const PetscInt*, const PetscScalar*, InsertMode)’:
> matrix.c:1993: warning: comparison between signed and unsigned integer expressions
> matrix.c:2005: warning: comparison between signed and unsigned integer expressions
> matrix.c: At global scope:
>

I pushed a fix.

BTW, I use cmake for building. Why I do not get these warnings? Are
you passing additional compiler flags?

Perhaps cmake is not using all the flags a regular "make" uses? See this:

$ gcc --version
gcc (GCC) 4.4.1 20090725 (Red Hat 4.4.1-2)
...

$ cd $PETSC_ARCH && make
...
[ 36%] Building C object
CMakeFiles/petsc.dir/src/vec/vec/utils/ftn-custom/zvscatf.c.o
/home/dalcinl/Devel/petsc-dev/src/vec/vec/utils/ftn-custom/zvscatf.c:
In function ‘vecscattercreate_’:
/home/dalcinl/Devel/petsc-dev/src/vec/vec/utils/ftn-custom/zvscatf.c:18:
warning: dereferencing type-punned pointer will break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/vec/vec/utils/ftn-custom/zvscatf.c:19:
warning: dereferencing type-punned pointer will break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/vec/vec/utils/ftn-custom/zvscatf.c:18:
warning: dereferencing pointer ‘ix.141’ does break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/vec/vec/utils/ftn-custom/zvscatf.c:18:
note: initialized from here
/home/dalcinl/Devel/petsc-dev/src/vec/vec/utils/ftn-custom/zvscatf.c:19:
warning: dereferencing pointer ‘iy.144’ does break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/vec/vec/utils/ftn-custom/zvscatf.c:19:
note: initialized from here
[ 36%] Building C object CMakeFiles/petsc.dir/src/vec/is/impls/stride/stride.c.o
...
[ 61%] Building C object
CMakeFiles/petsc.dir/src/mat/interface/ftn-custom/zmatrixf.c.o
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:
In function ‘matzerorows_’:
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:263:
warning: dereferencing type-punned pointer will break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:264:
warning: dereferencing type-punned pointer will break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:
In function ‘matzerorowsis_’:
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:270:
warning: dereferencing type-punned pointer will break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:271:
warning: dereferencing type-punned pointer will break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:
In function ‘matzerorowslocal_’:
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:277:
warning: dereferencing type-punned pointer will break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:278:
warning: dereferencing type-punned pointer will break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:
In function ‘matzerorowslocalis_’:
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:284:
warning: dereferencing type-punned pointer will break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:285:
warning: dereferencing type-punned pointer will break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:284:
warning: dereferencing pointer ‘x.271’ does break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:284:
note: initialized from here
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:285:
warning: dereferencing pointer ‘b.274’ does break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:285:
note: initialized from here
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:
In function ‘matzerorowslocal_’:
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:277:
warning: dereferencing pointer ‘x.258’ does break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:277:
note: initialized from here
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:278:
warning: dereferencing pointer ‘b.261’ does break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:278:
note: initialized from here
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:
In function ‘matzerorowsis_’:
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:270:
warning: dereferencing pointer ‘x.245’ does break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:270:
note: initialized from here
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:271:
warning: dereferencing pointer ‘b.248’ does break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:271:
note: initialized from here
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:
In function ‘matzerorows_’:
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:263:
warning: dereferencing pointer ‘x.232’ does break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:263:
note: initialized from here
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:264:
warning: dereferencing pointer ‘b.235’ does break strict-aliasing
rules
/home/dalcinl/Devel/petsc-dev/src/mat/interface/ftn-custom/zmatrixf.c:264:
note: initialized from here



-- 
Lisandro Dalcin
---------------
CIMEC (INTEC/CONICET-UNL)
Predio CONICET-Santa Fe
Colectora RN 168 Km 472, Paraje El Pozo
3000 Santa Fe, Argentina
Tel: +54-342-4511594 (ext 1011)
Tel/Fax: +54-342-4511169