TS grand plan

Lisandro Dalcin dalcinl at gmail.com
Thu Sep 24 13:53:21 CDT 2009


On Thu, Sep 24, 2009 at 10:00 AM, Barry Smith <bsmith at mcs.anl.gov> wrote:
>
>   TSType is the only type that has _ in the middle (SNES, KSP etc etc do
> not) therefor the correct fix is to remove the _
> from the middle of all TSType names and you can follow all the rules :-)
>
>   Barry

Agreed... we should change all the TS_<TYPENAME> to TS<TYPENAME> ...

However, I now think that we should have

#define TS_GENERAL_LINEAR  "general-linear"

as we already have "crank-nicholson" and "runge-kutta" ...

>
> On Sep 24, 2009, at 3:14 AM, Jed Brown wrote:
>
>> Lisandro Dalcin wrote:
>>>
>>> BTW, I think you should #define TS_GL "gl", instead of
>>> TS_GENERAL_LINEAR... Just to follow the rules... OTOH, you could
>>> #define TS_GENERAL_LINEAR "general-linear"...
>>
>> Yes, however this macro conflicts with the typedef TS_GL (also to follow
>> the rules).  I don't especially mind if the user has to type -ts_type
>> general-linear, but I certainly want to retain the prefix -ts_gl_*.
>> TS_GENERAL_LINEAR = "gl" was my compromise, but I can change it.
>>
>> Jed
>>
>
>



-- 
Lisandro Dalcín
---------------
Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
PTLC - Güemes 3450, (3000) Santa Fe, Argentina
Tel/Fax: +54-(0)342-451.1594



More information about the petsc-dev mailing list