missing CHKERRQ in MatNullSpaceRemove()

Lisandro Dalcin dalcinl at gmail.com
Thu Oct 29 13:59:33 CDT 2009


While trying to update petsc4py to latest changes in petsc-dev repo,
I've noticed that at the very end of MatNullSpaceRemove() we have:

 if (sp->remove){
    ierr = (*sp->remove)(sp,vec,sp->rmctx);
  }
  PetscFunctionReturn(0);
}

Any good reason for not CHKERRQ(ierr) after calling the userd-defined
remove function? I had a hard time figuring out what's going on
because a Python exception got lost at that point... Can any of you
fix this for me, please? BTW, perhaps CHKMEMQ macros should be used
there?

Thanks.




-- 
Lisandro Dalcín
---------------
Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
PTLC - Güemes 3450, (3000) Santa Fe, Argentina
Tel/Fax: +54-(0)342-451.1594



More information about the petsc-dev mailing list