[mpich2-dev] Null MPE log routines

[Lisandro Dalcin]

Here you have a tentative patch... Please note that the ONLY thing
that is important for me are the return statements. If you feel that
these "if (pointer) *pointer=value" are a nonsense, remove these lines
(or ask me to provide a new patch).

Regards,


On Fri, May 22, 2009 at 2:00 PM,  <chan at mcs.anl.gov> wrote:
>
> The idea of mpe_log_null.c is to disable the MPE calls in MPI
> program.  So whatever the returned arguments in the MPE should
> probably be irrelevant.  Send me the full patch, I will see if
> it makes sense as a whole and will try to integrate it to MPE.
>
> Thanks,
> A.Chan
>
> ----- "Lisandro Dalcin" <dalcinl at gmail.com> wrote:
>
>> Looking at mpe_log_null.c, IMHO some calls are not implemented the
>> right way... Below what I believe it should be doing:
>>
>> int MPE_Initialized_logging( void )
>> { return 1; }
>>
>> int MPE_Log_get_solo_eventID( int *eventdef_eventID )
>> { eventdef_eventID = -99999; return MPE_LOG_OK; }
>>
>> int MPE_Log_get_state_eventIDs( int *statedef_startID, int
>> *statedef_finalID )
>> { *statedef_startID = *statedef_finalID = -99999; return MPE_LOG_OK;
>> }
>>
>>
>> BTW, MPE_Initialized_logging() could be improved to also return 0, 1,
>> or 2 depending on the calls to MPI_Init_log() and MPI_Finish_log().
>>
>>
>> Would you accept a full patch for this?
>>
>>
>> --
>> Lisandro Dalcín
>> ---------------
>> Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
>> Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
>> Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
>> PTLC - Güemes 3450, (3000) Santa Fe, Argentina
>> Tel/Fax: +54-(0)342-451.1594
>



-- 
Lisandro Dalcín
---------------
Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
PTLC - Güemes 3450, (3000) Santa Fe, Argentina
Tel/Fax: +54-(0)342-451.1594
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpe_log_null.diff
Type: application/octet-stream
Size: 1620 bytes
Desc: not available
URL: <http://lists.mcs.anl.gov/pipermail/mpich2-dev/attachments/20090522/fb361864/attachment.obj>