[mpich2-dev] dataloop bug

[Rob Ross]

Hi David,

I think maybe I just responded to mpich2-dev the other day, which  
might explain why you didn't get my response.

I'm a little surprised that this wasn't found by the BG guys, because  
I thought they were also using ALL_BYTES, but from a less-than-cursory  
glance at the code, this appears to fix a real bug.

Thanks David,

Rob

On Aug 7, 2008, at 8:51 PM, David Gingold wrote:

> Rob Ross says that I should send this patch along.  It's a bug that  
> shows up only when ALL_BYTES is turned on in the dataloop code.  (In  
> the stock code it's not turned on.)
>
> Thanks for the help today, Rob!
>
> -dg
>
> ....
>
> --- dataloop_create_indexed.c.~1~	2008-08-05 15:09:54.619072000 -0400
> +++ dataloop_create_indexed.c	2008-08-07 14:05:46.049021000 -0400
> @@ -266,6 +266,8 @@
> 	    /* increase block lengths so they are in bytes */
> 	    tmp_blklen_array[i] *= old_extent;
> 	}
> +
> +	new_dlp->loop_params.i_t.total_blocks *= old_extent;
>     }
>
>     *dlp_p     = new_dlp;
>