[MOAB-dev] Moab and C++17

[Vijay S. Mahadevan]

> In response to Vijay -- we build our toolchain on multiple platforms
> (Windows VS, Windows LLVM, macOS same, Linux various compilers) using
> Jenkins as the driver and our own Bilder as a package manager for building
> and running tests.

Interesting. We build on various versions of Linux and macOS as well
using Jenkins and Buildbot. But we current don't have Jenkins support
on Windows at ANL AFAIK. We will have to talk to systems again to see
if they can set this up. I tried adding some support through AppVeyor
but that route may need some more work.

> To make sure I understand, we should branch off master -- after you get
> current PRs in.  Then add our code.  Then submit a pull request to your
> develop.  Is this right?

Yes, base your changes off master. The current PRs have been in the
pipeline for months. The requirements for those are VS2017 if I
remember right and I still had issues the last time I tried to build
the branch. If you already have MOAB working on Windows, I suspect
your changes and PR may be more complete potentially. But, if you see
changes in PR #405 as Paul suggested that are important/required,
please add them to your branch as well.

I'd rather have one complete PR to review and merge to master, instead
of multiple incomplete ones.

Vijay

On Tue, Oct 22, 2019 at 11:55 AM John R Cary via moab-dev
<moab-dev at mcs.anl.gov> wrote:
>
> Thanks, Paul.  We do have Moab ported to Windows and working, so we could
> set a PR, but first we have to sync-up, and there are lots of conflicts.
>
> So before we start on this, we would prefer that all other work on Windows
> ports be in so that we do not duplicate effort.  Would this be possible
> in a modest amount of time?
>
> In response to Vijay -- we build our toolchain on multiple platforms
> (Windows VS, Windows LLVM, macOS same, Linux various compilers) using
> Jenkins as the driver and our own Bilder as a package manager for building
> and running tests.
>
> To make sure I understand, we should branch off master -- after you get
> current PRs in.  Then add our code.  Then submit a pull request to your
> develop.  Is this right?
>
> Thx.....John
>
> On 10/22/19 11:27 AM, Paul Wilson wrote:
>
> Hi John,
>
> There have been a few attempts at a Windows port - or partial windows ports - that live in branches and/or PRs.  I'm most familiar with this one: https://bitbucket.org/fathomteam/moab/pull-requests/405 that Baptiste worked on.
>
> Paul
>
> On 10/22/19 10:11, John R Cary via moab-dev wrote:
>
> Thanks, Vijay.
>
> On a related note, we had started porting Moab to Windows.  When merging
> our changes to your develop branch, we found a number of conflicts.
>
> Did you port Moab to Windows?
>
> And you still want pull requests to your develop branch?
>
> Thx.....John
>
> On 10/22/19 10:24 AM, Vijay S. Mahadevan wrote:
>
> John,
>
> AFAIK, no one has verified this. If you already have some checks, please let us know and we will try to fix incompatibility. Or if you can submit changes as PRs, thst would be much appreciated.
>
> I do want to note that MOAB is C++03 compliant still and we only recently started adding new dependencies that have C++11 requirements.
>
> Thanks,
> Vijay
>
>
> On Tue., Oct. 22, 2019, 8:58 a.m. John R Cary via moab-dev, <moab-dev at mcs.anl.gov> wrote:
>>
>> We have recently ported most of our build chain to c++17.
>> However, our fork of moab is not c++-17 compliant.  Is the
>> main repo c++17 compliant?
>>
>> Thx....John Cary
>
>
> --
> -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ --
> Paul P.H. Wilson (he/him/his)
> Grainger Professor of Nuclear Engineering
> Chair, Department of Engineering Physics
> Chair, Energy Analysis and Policy Certificate
> 608-263-0807
> paul.wilson at wisc.edu
> 153 Engineering Research Bldg
> 1500 Engineering Dr, Madison, WI 53706
>
> Computational Nuclear Engineering Research Group
>
>