[MOAB-dev] MOABconfig.h

[Andrew Davis]

Vijay

If MOABconfig.h contains the moab version information then that is
sufficient for our needs.

Thanks

Andy

On Aug 21, 2016 1:30 PM, "Vijay S. Mahadevan" <vijay.m at gmail.com> wrote:

> Andy, yes I see that MOABConfig.h is now not installed. This is my
> bad. I was trying to make sure MOABConfig.h is not part of the
> distribution but my change affected the installations also. Thanks for
> verifying this.
>
> Also, Version.h is removed because all the defines are now available
> in MOABConfig.h. If there is a need for the original Version.h still,
> please let me know why.
>
> I'll push a fix to master soon. Thanks,
>
> Vijay
>
> On Sat, Aug 20, 2016 at 7:13 PM, Andrew Davis <andrew.davis at wisc.edu>
> wrote:
> > Also to be clear, Version.h has gone?
> >
> > On Sat, Aug 20, 2016 at 7:10 PM, Andrew Davis <andrew.davis at wisc.edu>
> wrote:
> >>
> >> Iulian
> >>
> >> We use Version.h, it just turns out our ifdef we incorrect so it wasn't
> >> being used properly. I'll write a test and pop it on in.
> >>
> >> So on our Docker based Ubuntu 14.04 build I consistently see this
> behavior
> >> where moab/MOABConfig.h is not correctly installed. It appears to be
> made,
> >> but not installed with make install. I've also built it on two different
> >> linux machines with the same result. It seems make install does not
> install
> >> the header into the include directory?
> >>
> >> Thanks
> >>
> >> Andy
> >>
> >> Thanks
> >>
> >> Andy
> >>
> >> On Fri, Aug 19, 2016 at 4:38 PM, Grindeanu, Iulian R. <
> iulian at mcs.anl.gov>
> >> wrote:
> >>>
> >>> MOABConfig.h should not be part of tar file, it was removed from
> >>> distribution. It should not be part of distribution. This change is
> part of
> >>> vijaysm/fix-dist (pull request #254)
> >>>
> >>> I don't know anything that uses moab/Version.h
> >>>
> >>> MOABConfig.h is built when you configure, not when you autoreconf -fi
> >>>
> >>>
> >>> Iulian
> >>> ________________________________
> >>> From: moab-dev-bounces at mcs.anl.gov [moab-dev-bounces at mcs.anl.gov] on
> >>> behalf of Andrew Davis [andrew.davis at wisc.edu]
> >>> Sent: Friday, August 19, 2016 4:17 PM
> >>> To: moab-dev at mcs.anl.gov
> >>> Subject: [MOAB-dev] MOABconfig.h
> >>>
> >>> Hi Folks
> >>>
> >>> Has MOABconfig.h been removed in the master branch? My autotools based
> >>> build seems to not have it any more? Also, does anyone know if there
> are any
> >>> tests that rely on moab/Version.h, I've only just noticed but it seems
> that
> >>> for my builds it doesn't actually do anything?
> >>>
> >>> Thanks
> >>>
> >>> Andy
> >>
> >>
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/moab-dev/attachments/20160822/cdfabef9/attachment.html>