[MOAB-dev] DAGMC CMakeFile

[Vijay S. Mahadevan]

> So conceptually, there could be a DAGMC_LINK_LIBS variable that was always
> part of MOAB_LINK_LIBS, but had no value unless a DAGMC variable was
> defined?

Yes. The variable will be available and populated when configured with
dagmc and be empty otherwise. If you can create a branch for review
(with a PR), we can get the changes merged.

Vijay

On Fri, Aug 29, 2014 at 11:37 AM, Paul Wilson <wilsonp at engr.wisc.edu> wrote:
> Hi again,
>
>
> On 08/29/2014 11:24 AM, Vijay S. Mahadevan wrote:
>>>
>>> I guess I'm not sure this is the desired behavior.  It's not really a big
>>> deal because dagmc is not that big, but just because dagmc has been built
>>> and exists doesn't mean that all uses of that MOAB installation will want
>>> to
>>> link dagmc into the executable.
>>
>> Sure that is fine. If you want, we can create a new variable that's
>> still part of moab.make that can be used by a dagmc based application
>> to link appropriately.
>>
>>> I think it makes more sense to have a separate dagmc.make or
>>> DAGMCconfig.cmake, but am interested in other thoughts.
>>
>> I'm against creating more files. moab.make and MOABConfig.cmake should
>> be a one stop shop for all things MOAB related. A user makefile should
>> include moab.make and know everything it needs to know about the
>> particular build.
>
>
> That makes sense...
>
> So conceptually, there could be a DAGMC_LINK_LIBS variable that was always
> part of MOAB_LINK_LIBS, but had no value unless a DAGMC variable was
> defined?
>
> Paul
>
>
>>
>> Vijay
>>
>> On Fri, Aug 29, 2014 at 11:10 AM, Paul Wilson <wilsonp at engr.wisc.edu>
>> wrote:
>>>
>>> Hi Vijay,
>>>
>>> I guess I'm not sure this is the desired behavior.  It's not really a big
>>> deal because dagmc is not that big, but just because dagmc has been built
>>> and exists doesn't mean that all uses of that MOAB installation will want
>>> to
>>> link dagmc into the executable.
>>>
>>> I think it makes more sense to have a separate dagmc.make or
>>> DAGMCconfig.cmake, but am interested in other thoughts.
>>>
>>> Paul
>>>
>>>
>>> On 08/29/2014 09:18 AM, Vijay S. Mahadevan wrote:
>>>
>>> If configured with dagmc, the linker libs should reflect that for MOAB in
>>> moab.make and the CMake config file. This is the case for MBCoupler and
>>> it
>>> should be done similarly.
>>>
>>> If you have changes, please submit a PR.
>>>
>>> Vijay
>>>
>>> On Aug 29, 2014 9:12 AM, "Andrew Davis" <davisa at engr.wisc.edu> wrote:
>>>>
>>>> Hi Dev's
>>>>
>>>> Would there be any objections to the inclusion of an -ldagmc in the
>>>> MOABconfig.cmake file?
>>>>
>>>> Or would the preference be to have a DAGMCconfig.cmake file which looks
>>>> an
>>>> awful lot like the MOAB one?
>>>>
>>>> Thanks
>>>>
>>>> Andy
>>>
>>>
>>> --
>>> -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ --
>>> Paul Wilson ~ UW-Madison ~ 608-263-0807 ~ cal: http://bit.ly/pphw-cal
>>> Professor, Engineering Physics. ~ http://cnerg.engr.wisc.edu
>>> Faculty Director, Advanced Computing Infrastructure
>
>
> --
> -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ --
> Paul Wilson ~ UW-Madison ~ 608-263-0807 ~ cal: http://bit.ly/pphw-cal
> Professor, Engineering Physics. ~ http://cnerg.engr.wisc.edu
> Faculty Director, Advanced Computing Infrastructure
>
>