[MOAB-dev] commit/MOAB: 4 new changesets

[Tim Tautges]

Several things bother me about this change:
> --- /dev/null
> +++ b/examples/GenLargeMesh.cpp

I think this name is too specific, and the allowed input is too constrained.  This example should be able to generate 
any structured mesh, not just a large one.  And, there are functions that will compute the right partition for you, so 
there shouldn't be any defaults for A/B/C.  Also, by convention in structured meshes, the parameters are usually I/J/K.


> diff --git a/src/moab/Interface.hpp b/src/moab/Interface.hpp

IMO, any changes to Interface.hpp should at least go through pull requests, and also should be discussed on the general 
list first.  I'm on the fence about is_valid being a function on Interface, but only because we have sets that don't 
track owners.  The reason you included it (to allow it being called by ParallelComm) IMO isn't a valid one.



> --- a/src/parallel/ParallelComm.cpp
> +++ b/src/parallel/ParallelComm.cpp
> @@ -8789,7 +8789,22 @@ ErrorCode ParallelComm::settle_intersection_points(Range & edges, Range & shared
>
>     return MB_SUCCESS;
>     // end copy
> +}
> +ErrorCode ParallelComm::correct_shared_entities()
> +{

I think this is fixing the symptom, not the problem.  Deleting entities should check with ParallelComm in parallel 
cases, and there should be a ParallelComm function for a collective delete entities that takes care of checking the sharers.

- tim

-- 
Timothy J. Tautges
Manager, Directed Meshing, CD-adapco
Phone: 608-354-1459
timothy.tautges at cd-adapco.com